Merge lp:~stevanr/lava-dashboard/fix-1198195 into lp:lava-dashboard

Proposed by Stevan Radaković
Status: Merged
Approved by: Senthil Kumaran S
Approved revision: 415
Merged at revision: 414
Proposed branch: lp:~stevanr/lava-dashboard/fix-1198195
Merge into: lp:lava-dashboard
Diff against target: 34 lines (+6/-4)
1 file modified
dashboard_app/static/dashboard_app/js/image-report.js (+6/-4)
To merge this branch: bzr merge lp:~stevanr/lava-dashboard/fix-1198195
Reviewer Review Type Date Requested Status
Senthil Kumaran S Approve
Linaro Automation & Validation Pending
Review via email: mp+180119@code.launchpad.net

Description of the change

Fix bug #1198195.
Remove storing of end build number.
Add default behavior for start build number to be end number minus 15.

To post a comment you must log in.
Revision history for this message
Senthil Kumaran S (stylesen) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'dashboard_app/static/dashboard_app/js/image-report.js'
--- dashboard_app/static/dashboard_app/js/image-report.js 2013-07-25 13:57:18 +0000
+++ dashboard_app/static/dashboard_app/js/image-report.js 2013-08-14 12:27:24 +0000
@@ -43,6 +43,12 @@
43 text: build_number43 text: build_number
44 }));44 }));
45 }45 }
46 start_number_options = $("#build_number_start option").size();
47 // Show last 15 options.
48 if (start_number_options > 15) {
49 start_number_options -= 15;
50 $("#build_number_start option:eq(" + start_number_options + ")").attr("selected", true);
51 }
46 $("#build_number_end option:last").attr("selected", true);52 $("#build_number_end option:last").attr("selected", true);
4753
48 for (iter in test_run_names) {54 for (iter in test_run_names) {
@@ -202,7 +208,6 @@
202208
203 $.jStorage.set(prefix + "_target_goal", $("#target_goal").val().trim());209 $.jStorage.set(prefix + "_target_goal", $("#target_goal").val().trim());
204 $.jStorage.set(prefix + "_build_number_start", $("#build_number_start").val());210 $.jStorage.set(prefix + "_build_number_start", $("#build_number_start").val());
205 $.jStorage.set(prefix + "_build_number_end", $("#build_number_end").val());
206 $.jStorage.set(prefix + "_test_select", $("#test_select").val());211 $.jStorage.set(prefix + "_test_select", $("#test_select").val());
207 $.jStorage.set(prefix + "_toggle_graph", $("#toggle_graph").attr("checked"));212 $.jStorage.set(prefix + "_toggle_graph", $("#toggle_graph").attr("checked"));
208 $.jStorage.set(prefix + "_graph_type", $('input:radio[name=graph_type]:checked').val());213 $.jStorage.set(prefix + "_graph_type", $('input:radio[name=graph_type]:checked').val());
@@ -225,9 +230,6 @@
225 if ($.jStorage.get(prefix + "_build_number_start")) {230 if ($.jStorage.get(prefix + "_build_number_start")) {
226 $("#build_number_start").val($.jStorage.get(prefix + "_build_number_start"));231 $("#build_number_start").val($.jStorage.get(prefix + "_build_number_start"));
227 }232 }
228 if ($.jStorage.get(prefix + "_build_number_end")) {
229 $("#build_number_end").val($.jStorage.get(prefix + "_build_number_end"));
230 }
231 if ($.jStorage.get(prefix + "_test_select")) {233 if ($.jStorage.get(prefix + "_test_select")) {
232 $("#test_select").val($.jStorage.get(prefix + "_test_select"));234 $("#test_select").val($.jStorage.get(prefix + "_test_select"));
233 }235 }

Subscribers

People subscribed via source and target branches