Merge lp:~devcamcar/nova-adminclient/fix-get-user into lp:nova-adminclient

Proposed by Devin Carlen
Status: Merged
Approved by: Devin Carlen
Approved revision: 6
Merged at revision: 6
Proposed branch: lp:~devcamcar/nova-adminclient/fix-get-user
Merge into: lp:nova-adminclient
Diff against target: 25 lines (+2/-2)
2 files modified
nova_adminclient/client.py (+1/-1)
setup.py (+1/-1)
To merge this branch: bzr merge lp:~devcamcar/nova-adminclient/fix-get-user
Reviewer Review Type Date Requested Status
Devin Carlen Approve
Review via email: mp+61851@code.launchpad.net

Description of the change

Modified get_user to check for the UserNotFound error from boto instead of NotFound to match recent changes to nova's exception handling.

To post a comment you must log in.
Revision history for this message
Devin Carlen (devcamcar) wrote :

approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'nova_adminclient/client.py'
--- nova_adminclient/client.py 2011-05-17 02:29:14 +0000
+++ nova_adminclient/client.py 2011-05-21 04:37:23 +0000
@@ -343,7 +343,7 @@
343 {'Name': name},343 {'Name': name},
344 UserInfo)344 UserInfo)
345 except boto.exception.BotoServerError, e:345 except boto.exception.BotoServerError, e:
346 if e.status == 400 and e.error_code == 'NotFound':346 if e.status == 400 and e.error_code == 'UserNotFound':
347 return None347 return None
348 raise348 raise
349349
350350
=== modified file 'setup.py'
--- setup.py 2011-05-17 03:07:21 +0000
+++ setup.py 2011-05-21 04:37:23 +0000
@@ -20,7 +20,7 @@
20from setuptools import setup, find_packages20from setuptools import setup, find_packages
2121
22setup(name = "nova-adminclient",22setup(name = "nova-adminclient",
23 version = "0.1.6",23 version = "0.1.7",
24 license = 'Apache License (2.0)',24 license = 'Apache License (2.0)',
25 description = "client for administering OpenStack Nova",25 description = "client for administering OpenStack Nova",
26 author = 'OpenStack',26 author = 'OpenStack',

Subscribers

People subscribed via source and target branches

to all changes: