nova-adminclient

Merge lp:~anotherjesse/nova-adminclient/set-region-in-connection-for into lp:nova-adminclient

  1. set-region-in-connection-for
  2. Merge into trunk
Proposed by Jesse Andrews
Status: Merged
Approved by: Devin Carlen
Approved revision: 6
Merged at revision: 5
Proposed branch: lp:~anotherjesse/nova-adminclient/set-region-in-connection-for
Merge into: lp:nova-adminclient
Diff against target: 25 lines (+2/-2)
2 files modified
nova_adminclient/client.py (+1/-1)
setup.py (+1/-1)
To merge this branch: bzr merge lp:~anotherjesse/nova-adminclient/set-region-in-connection-for
Reviewer Review Type Date Requested Status
Devin Carlen Approve
Review via email: mp+61192@code.launchpad.net

Description of the change

use passed region instead of self.region when creating new boto connection

To post a comment you must log in.
lp:~anotherjesse/nova-adminclient/set-region-in-connection-for updated
6. By Jesse Andrews

bump rev

Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'nova_adminclient/client.py'
--- nova_adminclient/client.py 2011-03-30 18:30:04 +0000
+++ nova_adminclient/client.py 2011-05-17 03:12:41 +0000
@@ -319,7 +319,7 @@
319 aws_secret_access_key=user.secretkey,319 aws_secret_access_key=user.secretkey,
320 is_secure=parts['is_secure'],320 is_secure=parts['is_secure'],
321 region=RegionInfo(None,321 region=RegionInfo(None,
322 self.region,322 region,
323 parts['ip']),323 parts['ip']),
324 port=parts['port'],324 port=parts['port'],
325 path='/services/Cloud',325 path='/services/Cloud',
326326
=== modified file 'setup.py'
--- setup.py 2011-03-31 01:40:43 +0000
+++ setup.py 2011-05-17 03:12:41 +0000
@@ -20,7 +20,7 @@
20from setuptools import setup, find_packages20from setuptools import setup, find_packages
2121
22setup(name = "nova-adminclient",22setup(name = "nova-adminclient",
23 version = "0.1.5",23 version = "0.1.6",
24 license = 'Apache License (2.0)',24 license = 'Apache License (2.0)',
25 description = "client for administering OpenStack Nova",25 description = "client for administering OpenStack Nova",
26 author = 'OpenStack',26 author = 'OpenStack',

Subscribers

People subscribed via source and target branches