Merge lp:~ahayzen/ubuntu-weather-app/fix-click-locations-list into lp:ubuntu-weather-app

Proposed by Andrew Hayzen
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 269
Merged at revision: 269
Proposed branch: lp:~ahayzen/ubuntu-weather-app/fix-click-locations-list
Merge into: lp:ubuntu-weather-app
Diff against target: 21 lines (+2/-2)
1 file modified
app/ui/LocationsPage.qml (+2/-2)
To merge this branch: bzr merge lp:~ahayzen/ubuntu-weather-app/fix-click-locations-list
Reviewer Review Type Date Requested Status
Michael Sheldon (community) Approve
Jenkins Bot continuous-integration Approve
Ubuntu Weather Developers Pending
Review via email: mp+322666@code.launchpad.net

Commit message

* Fix clicking on a location in the bottom edge not popping the bottom edge

Description of the change

* Fix clicking on a location in the bottom edge not popping the bottom edge

TESTING:
1) Ensure you have two locations
2) Open the bottom edge
3) Click on a location
4) The bottom edge should dismiss and the view switch to the chosen location

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Looks good :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'app/ui/LocationsPage.qml'
--- app/ui/LocationsPage.qml 2017-04-12 15:48:27 +0000
+++ app/ui/LocationsPage.qml 2017-04-18 09:09:34 +0000
@@ -73,7 +73,7 @@
7373
74 onItemClicked: {74 onItemClicked: {
75 settings.current = index;75 settings.current = index;
76 pageStack.pop()76 locationsPage.pop()
77 }77 }
7878
79 Column {79 Column {
@@ -161,7 +161,7 @@
161 settings.current = index;161 settings.current = index;
162 }162 }
163163
164 pageStack.pop()164 locationsPage.pop()
165 }165 }
166 onReorder: {166 onReorder: {
167 console.debug("Move: ", from, to);167 console.debug("Move: ", from, to);

Subscribers

People subscribed via source and target branches

to all changes: