Test suite fails on x86_64 OS X build

Bug #730931 reported by Daniel Johnson
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
subvertpy
Fix Released
High
Jelmer Vernooij
subvertpy (Debian)
Fix Released
Unknown
subvertpy (Ubuntu)
Fix Released
High
Unassigned

Bug Description

When building subvertpy 0.8.0 on Mac OS X x86_64 with any of 2.5, 2.6 or 2.7 pythons, I get the following test failure:
======================================================================
FAIL: test_transmit_text_deltas (subvertpy.tests.test_wc.AdmTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "subvertpy/tests/test_wc.py", line 240, in test_transmit_text_deltas
AssertionError: 1 != 4294967297

----------------------------------------------------------------------
Ran 154 tests in 29.462s

FAILED (failures=1)

The same test passes on a i386 build. It looks like a variable length mismatch somewhere; something is expecting a 32 bit value but gets a 64 bit one instead. That's a guess, since 4294967297 = 0x100000001 which is a 64 bit value and looks suspiciously like it's supposed to be 0x00000001, which is 32 bit.

Tags: macosx

Related branches

Jelmer Vernooij (jelmer)
Changed in subvertpy:
status: New → Triaged
status: Triaged → Incomplete
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

svn_revnum_t should be a long according to /usr/include/subversion-1/svn_types.h here and we use T_LONG in subvertpy/wc.c to access the revision member of svn_wc_entry_t.

Can you check the size of svn_revnum_t and see if it matches that of long?

tags: added: macosx
Revision history for this message
Daniel Johnson (daniel-daniel-johnson) wrote :

Yes, svn_revnum_t is typedef long int which is 64 bit here.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

In that case I don't really have a clue what's going wrong there. It seems like this should work.

Revision history for this message
Daniel Johnson (daniel-daniel-johnson) wrote :

Ok, I'll try to do some more debugging on my own and let you know if I find anything.

Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for subvertpy because there has been no activity for 60 days.]

Changed in subvertpy:
status: Incomplete → Expired
Jelmer Vernooij (jelmer)
Changed in subvertpy:
status: Expired → Triaged
importance: Undecided → Medium
Changed in subvertpy (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Changed in subvertpy:
importance: Medium → High
Changed in subvertpy (Ubuntu):
importance: Medium → High
Changed in subvertpy:
status: Triaged → In Progress
assignee: nobody → Jelmer Vernooij (jelmer)
Jelmer Vernooij (jelmer)
Changed in subvertpy:
status: In Progress → Fix Committed
Revision history for this message
Daniel Johnson (daniel-daniel-johnson) wrote :

This has fixed the test failure for me on 64 bit Mac OS X.

Thanks!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package subvertpy - 0.8.2+bzr2352-1

---------------
subvertpy (0.8.2+bzr2352-1) unstable; urgency=low

  * Add python-subvertpy-dbg package with debugging symbols.
  * New upstream snapshot.
   + Fixes test_transmit_text_deltas test. Closes: #625722, LP: #730931
 -- Ubuntu Archive Auto-Sync <email address hidden> Sun, 19 Jun 2011 03:58:09 +0000

Changed in subvertpy (Ubuntu):
status: Triaged → Fix Released
Jelmer Vernooij (jelmer)
Changed in subvertpy:
status: Fix Committed → Fix Released
status: Fix Released → Fix Committed
milestone: none → 0.8.3
Jelmer Vernooij (jelmer)
Changed in subvertpy:
status: Fix Committed → Fix Released
Changed in subvertpy (Debian):
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.