Ubuntu
ubuntu-dev-tools package

edit-patch should take an existing patch as an argument and apply it

Bug #586787 reported by Daniel Holbach
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-dev-tools (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: ubuntu-dev-tools

edit-patch should take an existing patch as an argument and apply it. Let's say I downloaded a patch for a package from Launchpad and I want to get it automatically applied using the right patch system and all the rest of it. edit-patch should handle this case.

"edit-patch apply <patch>"? Just "edit-patch bla.patch"?

Revision history for this message
Daniel Holbach (dholbach) wrote :

I think I like the latter better so we don't need to introduce a command line interface, but just check if the file exists.

Revision history for this message
David Futcher (bobbo) wrote :

I've talked to mvo and we decided that the best way to do this is to detect whether the patch already exists in debian/patches or whether it's a "local" patch on the filesystem that needs to be added. If it's the latter we copy it into debian/patches, add it to series/00list and then run edit-patch on it to make sure it applies and let the user make any edits that are required.

I've tested this patch on a couple of packages for each patchsys and haven't found any problems.

Michael Vogt (mvo)
Changed in ubuntu-dev-tools (Ubuntu):
status: New → Fix Committed
importance: Undecided → Wishlist
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-dev-tools - 0.100

---------------
ubuntu-dev-tools (0.100) maverick; urgency=low

  [ Luca Falavigna ]
  * syncpackage: new script to easily upload pristine Debian packages.
  * debian/ubuntu-dev-tools.preinst:
    - It is no longer necessary to remove stale pycentral files.

  [ Felix Geyer ]
  * reverse-build-depends: Always display the correct default distribution
    name in the usage text.

  [ Iain Lane ]
  * requestsync: Fall back to using rmadison when LP indicates that no new
    version is available. The LP importer is often out of date wrt Debian when
    rmadison isn't. (LP: #574398)

  [ Benjamin Drung ]
  * syncpackage:
    - add more options and allow pulling packages from Debian.
    - add mismatching source tarball detection (for fake syncs).
  * update-maintainer:
    - Remove duplicate Original-Maintainer field.
    - Avoid duplicate Original-Maintainer field if maintainer is listed in
      Uploaders too.

  [ Michael Vogt ]
  * edit-patch:
    - support full path to the patch as well (LP: #585599)
    - support adding existing patches (e.g. from launchpad)
      thanks to David Futcher (LP: #586787)

  [ Michael Bienia ]
  * Update to the new python-debian version:
    - Depend on python-debian >= 0.1.15
    - Replace imports of debian_bundle with debian to fix the deprecation
      warnings.

  [ Daniel Hahler ]
  * mk-sbuild: add $RELEASE to error message.
 -- Michael Bienia <email address hidden> Thu, 17 Jun 2010 21:17:10 +0200

Changed in ubuntu-dev-tools (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.