Ubuntu
apport package

[PATCH] Prefix staging driver suspend/resume bugs with [STAGING]

Bug #524174 reported by Leann Ogasawara on 2010-02-19

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	apport (Ubuntu)	Fix Released	Medium	Martin Pitt

Bug Description

Binary package hint: apport

This patch is dependent on the patch in bug 524167 being applied.

As noted in bug 524167, the linux kernel has a set of drivers technically maintained in the kernel but they really are held in a staging area. The goal for a driver in staging is to eventually be included in the main kernel tree and not just the staging area. The Ubuntu kernel team enables many of the drivers in staging to get wider exposure and testing of these drivers so that developmental improvements can be made to eventually help bring these drivers closer to mainline inclusion.

It was requested that suspend and hibernate bugs be prefixed with [STAGING] in the bug title if a staging driver was in use. See https://blueprints.edge.launchpad.net/ubuntu/+spec/kernel-lucid-suspend-resume - " apport -- tag / add subject when staging drivers are in use when reporting suspend/resume bugs". I've provided a patch in bug 524167 to generally detect and tag staging drivers. This is a follow on patch to specifically prefix suspend/hibernate bugs with "[STAGING]" in the bug title. I've attached the patch but will also inline below. Please consider applying. Thanks in advance.

=== modified file 'apport/report.py'
--- apport/report.py 2009-12-23 11:01:21 +0000
+++ apport/report.py 2010-02-19 00:35:40 +0000
@@ -923,6 +923,8 @@
             # Title the report with suspend or hibernate as appropriate,
             # and mention any non-free modules loaded up front.
             title = ''
+ if 'StagingDrivers' in self:
+ title += '[STAGING] '
             if 'MachineType' in self:
                 title += '[' + self['MachineType'] + '] '
             title += self['Failure'] + ' failure'

ProblemType: Bug
Architecture: i386
CheckboxSubmission: 27199aa7e30bbcb25cde0f30adca2f2c
CheckboxSystem: 8baff8f3b5cdd90914588b077dfd5f83
CrashReports:
600:0:0:75343:2010-02-17 18:17:00.000000000 -0800:2010-02-17 19:50:44.000000000 -0800:/var/crash/_usr_sbin_cron.0.crash
600:0:0:626095:2010-02-17 19:41:02.000000000 -0800:2010-02-17 19:47:55.000000000 -0800:/var/crash/kexec-tools.0.crash
600:1000:1000:32804:2010-02-18 16:22:37.000000000 -0800:2010-02-18 16:22:40.000000000 -0800:/var/crash/_usr_share_apport_apport-gtk.1000.crash
Date: Thu Feb 18 17:04:49 2010
DistroRelease: Ubuntu 10.04
Package: apport 1.12-0ubuntu5 [modified: usr/share/apport/package-hooks/source_linux.py]
PackageArchitecture: all
ProcEnviron:
PATH=(custom, user)
LANG=en_US.UTF-8
SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.32-13.18-generic
SourcePackage: apport
Uname: Linux 2.6.32-13-generic i686

See original description

Tags:

Related branches

lp:~ubuntu-core-dev/ubuntu/lucid/apport/ubuntu

lp:ubuntu/lucid/apport

Revision history for this message

Leann Ogasawara (leannogasawara) wrote on 2010-02-19:

ApportLog.txt Edit (6.4 KiB, text/plain; charset="utf-8")
Dependencies.txt Edit (1.4 KiB, text/plain; charset="utf-8")

report.diff Edit (545 bytes, text/plain)

Revision history for this message

Leann Ogasawara (leannogasawara) wrote on 2010-02-19:

I've also pushed this to a branch if that's easier.

https://code.edge.launchpad.net/~leannogasawara/ubuntu/lucid/apport/ubuntu

http://bazaar.launchpad.net/~leannogasawara/ubuntu/lucid/apport/ubuntu/revision/1626

Brian Murray (brian-murray) on 2010-02-19

tags:

added: patch

Brian Murray (brian-murray) on 2010-02-19

Changed in apport (Ubuntu):
assignee:	nobody → Martin Pitt (pitti)
status:	New → Triaged
importance:	Undecided → Medium

Leann Ogasawara (leannogasawara) on 2010-02-20

description:

updated

Revision history for this message

Martin Pitt (pitti) wrote on 2010-02-22:

Please note that the title should be set in the linux package hook, not in report.py. I'll adapted that with the merge. Thanks!

Changed in apport (Ubuntu):
status:	Triaged → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-02-22:

This bug was fixed in the package apport - 1.12.1-0ubuntu1

---------------
apport (1.12.1-0ubuntu1) lucid; urgency=low

  [ Martin Pitt ]
  * New upstream bug fix release:
    - launchpad.py: Do not keep escalating bugs, just escalate at the 10th
      duplicate.
    - Improve error message if a symptom script did not determine a package
      name. (LP: #503834)
    - general-hooks/generic.py: Fix crash on libGL check with empty
      StacktraceTop.
    - Review and clean up usage of chmod(). This fixes a small race condition
      in the Python exception hook where a local attacker could read the
      information from another user's crash report. (LP: #516029)
    - hookutils, package_versions(): Ignore "None" packages, for more robust
      package hooks. (LP: #518295)
  * debian/apport.install: Actually install the bash completion file.
    (LP: #218933)
  * Bump Standards-Version to 3.8.4 (no changes necessary).

  [ Leann Ogasawara ]
  * source_linux.py: Tag kernel bugs which utilize a driver from staging. Also
    provide the list of staging drivers in use. Prefix suspend/resume bug
    titles with "[STAGING]" if a staging driver was being used.
    (LP: #524174, #524167)
-- Martin Pitt <email address hidden> Mon, 22 Feb 2010 21:58:16 +0100