eucalyptus-common maintainer script should not add dpkg statoverrides

Bug #437012 reported by Steve Langasek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
eucalyptus (Ubuntu)
Fix Released
Low
Dustin Kirkland 

Bug Description

The eucalyptus-common maintainer script is calling dpkg-statoverride --add in the postinst for /usr/lib/eucalyptus/euca_rootwrap. Packages should *never* add dpkg statoverrides; statoverrides exist so that *admins* can tell dpkg to apply different permissions to a file. Since this file needs to have permissions that can't be shipped in the tarball (because we're using a non-standard group), the correct thing to do here is (pseudocode):

  if ! dpkg-statoverride --list /usr/lib/eucalyptus/euca_rootwrap; then
    chgrp [...]
    chmod [...]
 fi

This will leave a window between unpack and configure when the script has the wrong permissions, but packages are not guaranteed to be in a usable state during that window anyway.

When making the above change, additional cleanup handling should be done to identify any dpkg-statoverrides added by this package and remove them.

ProblemType: Bug
Architecture: amd64
Date: Fri Sep 25 19:37:38 2009
DistroRelease: Ubuntu 9.10
Package: eucalyptus-common (not installed)
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-10.35-generic
SourcePackage: eucalyptus
Uname: Linux 2.6.31-10-generic x86_64

Related branches

Steve Langasek (vorlon)
Changed in eucalyptus (Ubuntu):
status: New → Triaged
importance: Undecided → Low
Changed in eucalyptus (Ubuntu):
assignee: nobody → Dustin Kirkland (kirkland)
status: Triaged → In Progress
Changed in eucalyptus (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package eucalyptus - 1.6.2~bzr1103-0ubuntu1

---------------
eucalyptus (1.6.2~bzr1103-0ubuntu1) lucid; urgency=low

  [ Dustin Kirkland ]
  * Merge from Lucid's 1.6.1 tree, pull Colin's registration magic
  * Merge from upstream 1.6.2 tree
    - eucalyptus-cloud.install, eucalyptus-common.eucalyptus.upstart,
      eucalyptus-java-common.install, eucalyptus-sc.install,
      eucalyptus-walrus.install: jars are now named *-1.6.2.jar
    - debian/eucalyptus-java-common.install: db is packaged independently now,
      make sure this gets installed
    - debian/eucalyptus-java-common.links: install proxool.jar link
  * debian/eucalyptus-common.postinst: remove incorrect
    'dpkg-statoverride --add' calls, clean up existing ones, (LP: #437012)
  * Improve lintian cleanliness of this package
    - debian/control: bump standards version, no changes necessary
    - debian/README.source: add patch info
    - debian/eucalyptus-cc.templates, debian/eucalyptus-udeb.templates: drop
      useless imperative, fix too-long descriptions
    - debian/eucalyptus-cc.postinst, debian/eucalyptus-cloud.postinst,
      debian/eucalyptus-cloud.postrm, debian/eucalyptus-common.postinst,
      debian/eucalyptus-common.postrm, debian/eucalyptus-nc.config,
      debian/eucalyptus-nc.postinst: fix maintainer-script-ignores-errors
      lintian errors, this will need some testing and will probably
      involve some (needed) error handling in the maintainer scripts
    - debian/eucalyptus-common.install: fix lintian dir-or-file-in-var-run;
      create in the upstart script, rather than the install file
    - debian/control: fix lintian python-script-but-no-python-dep;
      depend on python
    - debian/eucalyptus-nc.postinst: fix postinst-does-not-load-confmodule,
      source it
    - debian/registration/common: fix script-not-executable, make executable
  * util/wrappers.conf: add /usr/sbin/ietadm, (LP: #497196)
  * clc/modules/bootstrap/eucalyptus-bootstrap.c: disable iscsi, (LP: #497196)
  * clc/modules/configuration/src/main/java/com/eucalyptus/config/Configuration.java:
    revert r582, as this is appropriately addressed now, no need to comment
    out this code
  * clc/modules/wsstack/src/main/java/com/eucalyptus/ws/handlers/WalrusRESTBinding.java:
    fix minor whitespace diff against upstream
  * debian/control, debian/eucalyptus-nc.eucalyptus-nc-publication.upstart,
    debian/eucalyptus-nc.install, debian/eucalyptus-nc.upstart, debian/rules:
    migrate the NC init to upstart, LP: #438631
  * debian/30-eucalyptus-nc.conf, debian/eucalyptus-nc.install,
    debian/eucalyptus-nc.upstart: use sysctl to load the eucalyptus-nc
    networking settings

  [ Thierry Carrez ]
  * Move eucalyptus-interface-1.6-devel.jar from eucalyptus-cloud to
    eucalyptus-java-common, since it is needed on Walrus and SC (LP: #494765)
  * Fix dependencies: Remove c3p0 dependencies, add proxool, woodstox and
    euca-commons-ext >=0.5.0

  [ Mathias Gug ]
  * debian/control: Add wget as an eucalyptus-cc dependency (required by
    eucalyptus-cc upstart job).
 -- Dustin Kirkland <email address hidden> Thu, 17 Dec 2009 18:22:02 -0600

Changed in eucalyptus (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.