gnome-system-tools: mnemonic/accelerator shows as underscore instead of underline, and does not register with keyboard

Look at "_Unlock" button.

Look at "Find _Next" button.

Thank you for your bug report, not sure if that's a gtk issue or a bug in those softwars

I can confirm the problem too. It is interesting that the underscore accelerator works sometimes. I have not been able to find a rule when this happens.

Hi,

I just did a fresh Karmic Alpha 3 install and noticed this bug in Xchat. The network list shows C_onnect. I checked the upstream source and .po files and contacted upstream who confirmed this is correct behaviour, and suggested the problem must be in the gtk stack somewhere.

LANG=en_US.UTF-8

Interestingly, all the other accelerators on that same form display and function as expected.

the issue is a bug in those softwares not using use_underline, reassigning to gnome-system-tools for the users-admin issue open new bugs about other softwares

Yup. To fix it, edit src/common/gst-polkit-button.c under gnome-system-tools:

line ~262
 return g_object_new (GST_TYPE_POLKIT_BUTTON,
        "action", action,
        "label", label,
        "use-underline", TRUE, /* add this to fix the problem */
        NULL);

This debdiff fixes all the programs in gnome-system-tools and gnome-network-admin. They use this common file to make the PolicyKit Unlock button.

I just noticed that Epiphany's "Clear history" dialog has the same problem.

Atanas Atanasov:

See Bug 407596

Umm we're absolutely sure this is a bug in each individual package, right?

Something must have changed in gtk that caused use-underline to be false by default. I don't know what would have caused all these packages to suddenly have problems.

Anyway if you see any other problems please open another bug and link me to it, or alert me to the program, and I'll post a debdiff for it.

thank you for your work there

This bug was fixed in the package gnome-system-tools - 2.27.2-0ubuntu2

---------------
gnome-system-tools (2.27.2-0ubuntu2) karmic; urgency=low

  * debian/patches/84_polkit-btn-use-underline.patch:
    - Enable "use-underline" for polkit button so that accelerator
    works. (LP: #404767)

 -- Andy Matteson <email address hidden> Fri, 31 Jul 2009 10:58:37 -0400

Hey, what's the joke here? Why did you add this patch to the Ubuntu package of the gnome-system-tools without even reporting it upstream? If we're sure that's the right thing to do, I'd have committed it in a few hours!

Now, could you make the status of this bug clearer? The GTK+ upstream bug is not explicit about what could have changed WRT default behavior of underline. And to me, PolicyKit should allow us to create such buttons without tuning the "use-underline" option at all.

OK, the problem has nothing to do with PolicyKit. That's only a change in GTK+ that affects the internals of g-s-t. I guess your patch (or something similar) is the way to go upstream, if we're sure the new default will stay.

Milan:

I did report this upstream in gtk.
http://bugzilla.gnome.org/show_bug.cgi?id=590656

There's bugs in xchat, epiphany-browser, and gnome-applets too. All these apps suddenly being broken seemed like gtk to me. The reply I got was that there was a fix for gtk and glade that should have fixed it. I did not have time to test this on my machine. Therefore I didn't report it in GST yet. Also, I don't think another bug report is needed, maybe only a modification to the original one if the bug wasn't *actually* in GTK?

As to why Ubuntu posted my fix I don't know. I don't have that power. It wasn't my intention until it was cleared up whether the bug was in gtk or each individual program. And at this point I still don't know why this isn't in gtk?

So your fix is the right one, but in the meantime we've moved to PolicyKit1, which allows us to replace that button with their stock unlock button. So that will be fixed in the upcoming 2.27.3, and you'll be able to drop the patch (which won't apply anyway). Thanks for your interest!