spl fails to unregister sysctl entries

Bug #2034510 reported by Andrea Righi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
zfs-linux (Ubuntu)
Fix Released
Undecided
Unassigned
Mantic
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

On unload the spl module is not properly cleaning up the registered sysctl entries with kernel 6.5 in Mantic:

06:58 ubuntu@mantic$ sudo modprobe spl
modprobe: ERROR: could not insert 'spl': Protocol driver not attached
06:58 ubuntu@mantic$ sudo dmesg | grep duplicate
[ 152.587197] sysctl duplicate entry: /kernel/spl/kmem/slab_kvmem_total

[Test case]

Uninstall zfsutils-linux and try to `modprobe -r zfs; modprobe -r spl`, then `modprobe zfs` again and you should see the error (with a failure to load spl again).

At this point it is possible to load spl again only after a reboot.

[Fix]

Properly cleanup all the registered sysctl entries when the spl module is unloaded.

[Regression potential]

We may experience regressions in systems that are using zfs with the 6.5 kernel.

ProblemType: Bug
DistroRelease: Ubuntu 23.10
Package: zfs-dkms 2.2.0~rc3-0ubuntu3
ProcVersionSignature: User Name 6.5.0-4.4-generic 6.5.0
Uname: Linux 6.5.0-4-generic x86_64
ApportVersion: 2.27.0-0ubuntu2
Architecture: amd64
CasperMD5CheckResult: unknown
CloudArchitecture: x86_64
CloudBuildName: server
CloudID: nocloud
CloudName: unknown
CloudPlatform: nocloud
CloudSerial: 20230823
CloudSubPlatform: config-disk (/dev/vdb)
Date: Wed Sep 6 07:06:33 2023
PackageArchitecture: all
ProcEnviron:
 LANG=C.UTF-8
 PATH=(custom, no user)
 SHELL=/bin/bash
 TERM=xterm-256color
 XDG_RUNTIME_DIR=<set>
SourcePackage: zfs-linux
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Andrea Righi (arighi) wrote :
Revision history for this message
Andrea Righi (arighi) wrote :

Upstream pull request to fix this issue: https://github.com/openzfs/zfs/pull/15239

Revision history for this message
Andrea Righi (arighi) wrote :

Attached debdiff seems to fix the bug (reproduced and tested in a local VM with the latest Mantic 6.5 kernel).

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "spl-fix.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Graham Inggs (ginggs)
Changed in zfs-linux (Ubuntu Mantic):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package zfs-linux - 2.2.0~rc3-0ubuntu4

---------------
zfs-linux (2.2.0~rc3-0ubuntu4) mantic; urgency=medium

  * Properly unregister sysctl entries when spl is unloaded (LP: #2034510):
    - debian/patches/4635-Linux-6.5-compat-spl-properly-unregister-sysctl-entr.patch

 -- Andrea Righi <email address hidden> Wed, 06 Sep 2023 09:03:35 +0200

Changed in zfs-linux (Ubuntu Mantic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.