zfs-dkms fails to build on jammy with linux 5.19

Bug #2003174 reported by Andrea Righi
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
zfs-linux (Ubuntu)
Invalid
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned

Bug Description

[Impact]

zfs-dkms fails to build on jammy with the latest linux hwe 5.19:

  *** ZFS Version: zfs-2.1.4-0ubuntu0.1
  *** Compatible Kernels: 3.10 - 5.17

[Test case]

 $ sudo apt install zfs-dkms

[Fix]

The most reliable fix is probably to move to the same version that is available in kinetic, since there's no significant ABI change in this way we should be able to support both 5.15 and 5.19 kernels.

[Regression potential]

We may experience zfs regressions if there's a format/ABI incompatibility with volumes created with the previous version.

Revision history for this message
Andrea Righi (arighi) wrote :

debdiff in attach (that doesn't change anything, it's basically a resync of the same version in kinetic, recompiled with the jammy toolchain).

With this applied I was able to successfully run ubuntu_zfs_smoke_test and ubuntu_zfs_stress both on 5.15 and 5.19.

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

fixed the version as -1ubuntu6~22.04.1 because it can't be bigger than in newer releases

Changed in zfs-linux (Ubuntu):
status: New → Incomplete
status: Incomplete → Invalid
Changed in zfs-linux (Ubuntu Jammy):
status: New → In Progress
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

I don't feel comfortable accepting this SRU in the current form. I'm happy to hear that there's 'no significant ABI changes' in this version, but basically doing a new upstream release with a diff of 556 files changed, 48365 insertions(+), 23626 deletions(-) with only "$ sudo apt install zfs-dkms" as the test case is not acceptable.

This should ideally be a cherry-picked fix. Will reject it for now.

Revision history for this message
Łukasz Zemczak (sil2100) wrote : Proposed package upload rejected

An upload of zfs-linux to jammy-proposed has been rejected from the upload queue for the following reason: "Please see https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/2003174/comments/3 for the rationale.".

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

zfs-linux SRUs, should follow the regular SRU testing process which covers all bases.

In the past we have used these:

[Test Plan]

 * autopkgtest pass

 * kernel regression zfs testsuite pass

 * zsys integration test pass

The first two cover unit, functional, and integration tests. Whilst the last one covers full-end-to-end zfs-on-root systems with snapshotting.

More details guidelines are available internally in a google doc shared with kernel team, on how to execute them.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Thank you Dimitri! If these will be run for the package in -proposed as part of the validation, I'll accept the new upload from the Rejected queue.

Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Andrea, or anyone else affected,

Accepted zfs-linux into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/zfs-linux/2.1.5-1ubuntu6~22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in zfs-linux (Ubuntu Jammy):
status: In Progress → Fix Committed
Revision history for this message
Andrea Righi (arighi) wrote :

I just tested autopkgtest and our kernel regression zfs testsuite (ubuntu_zfs, ubuntu_zfs_fstest, ubuntu_zfs_smoke_test, ubuntu_zfs_stress, ubuntu_zfs_xfs_generic) both with the new 5.19 kernel and stock 5.15 in jammy. Everything looks good, no error. I'm trying to figure out how to test the zsys integration, but I'd consider this a success already (I think we usually used to run just autopkgtest and regression tests in the past), maybe we can speed things up if xnox thinks this is enough to determine the goodness of this package, otherwise we can wait a little longer and I can provide a result also for the zsys integration.

tags: added: verification-done-jammy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package zfs-linux - 2.1.5-1ubuntu6~22.04.1

---------------
zfs-linux (2.1.5-1ubuntu6~22.04.1) jammy; urgency=medium

  * No change, rebuild with the jammy toolchain (LP: #2003174).

 -- Andrea Righi <email address hidden> Wed, 18 Jan 2023 08:18:30 +0000

Changed in zfs-linux (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for zfs-linux has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.