dkms-autopkgtest: Also select binary packages that depends on dkms for testing

Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982315

In bionic, `dkms-autopkgtest` doesn't restrict binary packages by name and thus the fix is only necessary for focal and newer series.

I've attached the debdiff with the fix for all the necessary series, but the source packages are also available at:

https://kernel.ubuntu.com/~mhcerri/4review/lp1915051/

Hello Marcelo, or anyone else affected,

Accepted dkms into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dkms/2.8.3-4ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Marcelo, or anyone else affected,

Accepted dkms into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/dkms/2.8.1-5ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

The Hirsute fix is in hirsute-proposed.

All autopkgtests for the newly accepted dkms (2.8.1-5ubuntu2) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

nvidia-graphics-drivers-390/390.141-0ubuntu0.20.04.1 (armhf)
virtualbox-hwe/6.1.16-dfsg-6ubuntu1.20.04.1 (ppc64el, armhf, s390x, arm64)
west-chamber/20100405+svn20111107.r124-12 (ppc64el, armhf, s390x, arm64, amd64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#dkms

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

All autopkgtests for the newly accepted dkms (2.8.3-4ubuntu0.1) for groovy have finished running.
The following regressions have been reported in tests triggered by the package:

virtualbox-hwe/6.1.16-dfsg-6ubuntu1.20.10.1 (ppc64el, s390x, armhf, arm64)
nvidia-graphics-drivers-390/390.141-0ubuntu0.20.10.1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/groovy/update_excuses.html#dkms

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Verification results for focal:

bcmwl is an example of a package that is not currently being built automatically:
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/amd64/b/bcmwl/20210205_105527_d024f@/log.gz

Running autopkgtest locally with dkms 2.8.1-5ubuntu2 it gets built:
================================================
autopkgtest [15:11:14]: test dkms-autopkgtest: /usr/lib/dkms/dkms-autopkgtest
autopkgtest [15:11:14]: test dkms-autopkgtest: [-----------------------
(Reading database ... 312652 files and directories currently installed.)
Removing dkms (2.8.1-5ubuntu2) ...
Processing triggers for man-db (2.9.1-1) ...
I: removing binary package bcmwl-kernel-source, to get clean state
I: Installing binary package bcmwl-kernel-source
Reading package lists...
Building dependency tree...
Reading state information...
The following additional packages will be installed:
  dkms
Suggested packages:
  menu
The following NEW packages will be installed:
  bcmwl-kernel-source dkms
0 upgraded, 2 newly installed, 0 to remove and 83 not upgraded.
Need to get 66.8 kB/1620 kB of archives.
After this operation, 8367 kB of additional disk space will be used.
Get:1 file:/tmp/autopkgtest.L09GqF/binaries bcmwl-kernel-source 6.30.223.271+bdcom-0ubuntu7~20.04.1 [1553 kB]
Get:2 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 dkms all 2.8.1-5ubuntu2 [66.8 kB]
Fetched 66.8 kB in 0s (290 kB/s)
Selecting previously unselected package dkms.
(Reading database ... 312624 files and directories currently installed.)
Preparing to unpack .../dkms_2.8.1-5ubuntu2_all.deb ...
Unpacking dkms (2.8.1-5ubuntu2) ...
Selecting previously unselected package bcmwl-kernel-source.
Preparing to unpack ..././bcmwl-kernel-source.deb ...
Unpacking bcmwl-kernel-source (6.30.223.271+bdcom-0ubuntu7~20.04.1) ...
Setting up dkms (2.8.1-5ubuntu2) ...
Setting up bcmwl-kernel-source (6.30.223.271+bdcom-0ubuntu7~20.04.1) ...
Loading new bcmwl-6.30.223.271+bdcom DKMS files...
Building for 5.4.0-66-generic 5.8.0-44-generic
Building for architecture x86_64
Building initial module for 5.4.0-66-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

wl.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.4.0-66-generic/updates/dkms/

depmod...

DKMS: install completed.
Building initial module for 5.8.0-44-generic
EFI variables are not supported on this system
/sys/firmware/efi/efivars not found, aborting.
Done.

wl.ko:
Running module version sanity check.
 - Original module
   - No original module exists within this kernel
 - Installation
   - Installing to /lib/modules/5.8.0-44-generic/updates/dkms/

depmod...

DKMS: install completed.
update-initramfs: deferring update (trigger activated)
Processing triggers for man-db (2.9.1-1) ...
Processing triggers for initramfs-tools (0.136ubuntu6.3) ...
update-initramfs: Generating /boot/initrd.img-5.8.0-44-generic
I: Testing binary package bcmwl-kernel-source
I: Testing if bcmwl modules are correctly installed
bcmwl, 6.30.223.271+...

Verification results for groovy:

bcmwl is an example of a package that is not currently being built automatically:
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy/groovy/amd64/b/bcmwl/20210210_143008_c07d5@/log.gz

Running autopkgtest locally with dkms 2.8.3-4ubuntu0.1 it gets built:
================================================
autopkgtest [17:04:13]: test dkms-autopkgtest: /usr/lib/dkms/dkms-autopkgtest
autopkgtest [17:04:13]: test dkms-autopkgtest: [-----------------------
I: Removing binary package bcmwl-kernel-source, to get clean state
I: Installing binary package bcmwl-kernel-source
Reading package lists...
Building dependency tree...
Reading state information...
The following NEW packages will be installed:
  bcmwl-kernel-source
0 upgraded, 1 newly installed, 0 to remove and 50 not upgraded.
Need to get 0 B/1551 kB of archives.
After this operation, 8071 kB of additional disk space will be used.
Get:1 file:/tmp/autopkgtest.1cGFPr/binaries bcmwl-kernel-source 6.30.223.271+bdcom-0ubuntu7 [1551 kB]
Selecting previously unselected package bcmwl-kernel-source.
(Reading database ... 121777 files and directories currently installed.)
Preparing to unpack ..././bcmwl-kernel-source.deb ...
Unpacking bcmwl-kernel-source (6.30.223.271+bdcom-0ubuntu7) ...
Setting up bcmwl-kernel-source (6.30.223.271+bdcom-0ubuntu7) ...
autoinstall for dkms modules has been disabled.
modprobe: FATAL: Module wl not found in directory /lib/modules/5.8.0-44-generic
update-initramfs: deferring update (trigger activated)
Processing triggers for initramfs-tools (0.137ubuntu12) ...
update-initramfs: Generating /boot/initrd.img-5.8.0-44-generic
dpkg: dependency problems prevent removal of dkms:
 bcmwl-kernel-source depends on dkms.

dpkg: error processing package dkms (--remove):
 dependency problems - not removing
Errors were encountered while processing:
 dkms
I: Testing binary package bcmwl-kernel-source
I: Trying to build bcmwl/6.30.223.271+bdcom for 5.8.0-41-generic

Creating symlink /var/lib/dkms/bcmwl/6.30.223.271+bdcom/source ->
                 /usr/src/bcmwl-6.30.223.271+bdcom

DKMS: add completed.

Kernel preparation unnecessary for this kernel. Skipping...
applying patch 0002-Makefile.patch...patching file Makefile
Hunk #1 succeeded at 113 with fuzz 1.
Hunk #2 succeeded at 132 with fuzz 2 (offset 1 line).

applying patch 0003-Make-up-for-missing-init_MUTEX.patch...patching file src/wl/sys/wl_linux.c
Hunk #1 succeeded at 111 with fuzz 2 (offset 12 lines).

applying patch 0010-change-the-network-interface-name-from-eth-to-wlan.patch...patching file src/wl/sys/wl_linux.c
Hunk #1 succeeded at 221 (offset -14 lines).

applying patch 0013-gcc.patch...patching file Makefile

applying patch 0019-broadcom-sta-6.30.223.248-3.18-null-pointer-fix.patch...patching file src/wl/sys/wl_linux.c
Hunk #1 succeeded at 2169 (offset 12 lines).

applying patch 0020-add-support-for-linux-4.3.patch...patching file src/shared/linux_osl.c

applying patch 0021-add-support-for-Linux-4.7.patch...patching file src/wl/sys/wl_cfg80211_hybrid.c

applying patch 0022-add-support-for-Linux-4.8.patch...patching file src/wl/sys/wl_cf...

I have reviewed the update_excuses failures and none of them should block the release of 'dkms'.

The following failures can be hinted by the kernel team:

Focal:
- nvidia-graphics-drivers-390/390.141-0ubuntu0.20.04.1: the armhf regression was caused by a kernel patch and not by the new dkms upload.
- virtualbox-hwe/6.1.16-dfsg-6ubuntu1.20.04.1: virtualbox is not expected to work for non-x86 arches.
- west-chamber/20100405+svn20111107.r124-12: this is a known failure and it's being handled on bug 1912783.

Groovy:
- nvidia-graphics-drivers-390/390.141-0ubuntu0.20.10.1: same as in Focal.
- virtualbox-hwe/6.1.16-dfsg-6ubuntu1.20.10.1: same as in Focal.

The fix/hints should come from hirsute, because the package never migrated there to release pocket.

Just a quick question regarding the virtualbox failures, what I'd like to know: why did the tests pass with the old dkms package version? If you check the ADT test history for groovy for instance, the tests for non-amd64 arches only fail with the new dkms. I understand they might not be meant to work for non-x86, but I'm just curious why suddenly they are now failing.

Hi, Łukasz.

I believe they were passing simply because the DKMS tests weren't being triggered. Those past tests were run with the old version of dkms-autopkgtest (from dkms) and thus only binary packages with names ending with "-dkms" were tested by it (whick is not the case for virtualbox-hwe).

Ok, sounds convincing enough. Let's proceed then!

This bug was fixed in the package dkms - 2.8.3-4ubuntu0.1

---------------
dkms (2.8.3-4ubuntu0.1) groovy; urgency=medium

  * dkms-autopkgtest: Also select binary packages that depends on dkms for testing
    (LP: #1915051)

 -- Marcelo Henrique Cerri <email address hidden> Thu, 11 Feb 2021 12:02:19 -0300

The verification of the Stable Release Update for dkms has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package dkms - 2.8.1-5ubuntu2

---------------
dkms (2.8.1-5ubuntu2) focal; urgency=medium

  * dkms-autopkgtest: Also select binary packages that depends on dkms for testing
   (LP: #1915051)

 -- Marcelo Henrique Cerri <email address hidden> Thu, 11 Feb 2021 12:05:43 -0300

This bug was fixed in the package dkms - 2.8.4-2

---------------
dkms (2.8.4-2) unstable; urgency=medium

  [ Gianfranco Costamagna ]
  * Team upload

  [ Andreas Beckmann ]
  * Add Provides: dh-sequence-dkms to help reverse-dependencies use it. (Closes: #981395)

  [ Marcelo Henrique Cerri ]
  * dkms-autopkgtest: Also select binary packages that depends on dkms for testing (LP: #1915051)
    Closes: #982315

 -- Marcelo Henrique Cerri <email address hidden> Thu, 11 Feb 2021 11:56:32 -0300