Ubuntu
update-notifier package

Resolve autopkgtest failures Pep8/pyflakes on Xenial and Bionic

Bug #1906436 reported by Chad Smith on 2020-12-01

This bug affects 1 person

	Status	Importance	Assigned to
update-notifier (Ubuntu)	Fix Released	Undecided	Unassigned
Xenial	Fix Released	Undecided	Unassigned
Bionic	Fix Released	Undecided	Unassigned

Bug Description

[Impact]

- autopkgtest failures on for Xenial(pep8) and Bionic(pep8 & pyflakes)

- Cherry-picking upstream changes for ESM Product renaming and messaging
for bug 1901627 trigger these issues.

- Also changes in the Xenial base cloud-images used for testing dropped
  pep8 package from the build environment and unittests rely on calling
  pep8 on Xenial and Bionic. minimally a build-depends on pep8 needs to be
  added and pep8 test failures addresssed for Xenial. Bionic also needs
  minor pyflakes fixes from master.

[Test Case]

* Testing is "implicit", build time and autopkgtest tests have to
succeed as we'd expect anyway.

[Where problems could occur]

* These are whitespace/indent/style changes that should (tm) be totally
   without an effect other than for the code-checker. Never the less by
   changing code always something could happen. In this case the changes
   are local to apt_check, package-data-downloader, backend_helper and
   hooks. So in these subfunctions of update-notifier issue would be
   expected.

[Other Info]

* This does not directly affect Focal or later because update-notifier
   moved to pycodestyle validation in tests instead of using pep8.
* The Xenial upload will throw errors of some epxect-to-fail tests that
   are misleading. We've spent too many iterations on looking at these so
   they are silenced while fixing the test anyway.

--- ---

Initial pep8 build-dependency error on Xenial/Bionic autopkgtests:

Fetched 4 B in 0s (0 B/s)
....Get:1 http://localhost:17195/canary-file.txt [4 B]
Fetched 4 B in 0s (0 B/s)
.E
======================================================================
ERROR: test_pep8_clean (test_pep8.TestPep8Clean)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/autopkgtest.RQGkx9/build.3cC/src/tests/test_pep8.py", line 32, in test_pep8_clean
    ["pep8", "--ignore={0}".format(IGNORE_PEP8), py_file])
  File "/usr/lib/python3.5/subprocess.py", line 557, in call
    with Popen(*popenargs, **kwargs) as p:
  File "/usr/lib/python3.5/subprocess.py", line 947, in __init__
    restore_signals, start_new_session)
  File "/usr/lib/python3.5/subprocess.py", line 1551, in _execute_child
    raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: 'pep8'

Once resolving the build-depends: example pep8 test failures: seen running nosetests3 on update-notifier on Xenial amd Bionic

./tmp/autopkgtest.wN63go/build.IFg/src/tests/../data/apt_check.py:157:21: W503 line break before binary operator ....

autopackage test failure logs showing missing pep8 dependency:

xenial: update-notifier/3.168.11
- autopkg logs: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/u/update-notifier/20201016_043912_51752@/log.gz

bionic: update-notifier/3.192.1.8
- autopkg failures: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/u/update-notifier/20201016_045656_8c126@/log.gz

focal: update-notifier/3.192.30.1
- rejected this upload in Focal to reduce SRU thrashing because a followup will be provided for Focal anyway to sync with Xenial and Bionic.

See original description

Tags:

Related branches

~lamoura/ubuntu/+source/update-notifier:pro-bionic-release

Superseded for merging into ubuntu/+source/update-notifier:ubuntu/devel

git-ubuntu import: Pending requested 2022-09-22

Diff: 29251 lines (+12561/-0) (has conflicts)

173 files modified

.bzr-builddeb/default.conf (+5/-0)
.bzrignore (+31/-0)
autogen.sh (+17/-0)
config.h.in (+3/-0)
configure.ac (+11/-0)
data/Makefile.am (+11/-0)
data/apt_check.py (+46/-0)
data/backend_helper.py (+6/-0)
data/com.ubuntu.update-notifier.gschema.xml.in (+4/-0)
data/notify-reboot-required (+3/-0)
data/package-data-downloader (+6/-0)
data/update-motd-fsck-at-reboot (+7/-0)
data/update-motd-hwe-eol (+14/-0)
data/update-motd-updates-available (+3/-0)
debian/90-updates-available (+3/-0)
debian/95-hwe-eol (+3/-0)
debian/changelog (+128/-0)
debian/compat (+4/-0)
debian/control (+28/-0)
debian/rules (+7/-0)
debian/systemd/unicast-local-avahi.override (+1/-0)
debian/systemd/unicast-local-avahi.path (+6/-0)
debian/systemd/unicast-local-avahi.service (+6/-0)
debian/systemd/update-notifier-crash.path (+3/-0)
debian/systemd/update-notifier-crash.service (+6/-0)
debian/tests/control (+4/-0)
debian/unicast-local-avahi.conf (+14/-0)
debian/update-notifier-common.cron.daily (+8/-0)
debian/update-notifier-common.cron.weekly (+15/-0)
debian/update-notifier-common.install (+6/-0)
debian/update-notifier-common.postinst (+7/-0)
debian/update-notifier-common.postrm (+8/-0)
debian/update-notifier-common.preinst (+8/-0)
debian/update-notifier-common.triggers (+4/-0)
debian/update-notifier-crash (+3/-0)
debian/update-notifier.install (+21/-0)
debian/update-notifier.links (+4/-0)
pixmaps/scalable/livepatch-on.svg (+1/-0)
pixmaps/scalable/livepatch-warning.svg (+1/-0)
po/POTFILES.in (+10/-0)
po/ace.po (+93/-0)
po/af.po (+103/-0)
po/am.po (+97/-0)
po/an.po (+100/-0)
po/ar.po (+106/-0)
po/ast.po (+102/-0)
po/az.po (+96/-0)
po/be.po (+103/-0)
po/bem.po (+93/-0)
po/bg.po (+102/-0)
po/bn.po (+102/-0)
po/bo.po (+93/-0)
po/br.po (+102/-0)
po/bs.po (+103/-0)
po/ca.po (+103/-0)
po/ca@valencia.po (+103/-0)
po/ckb.po (+96/-0)
po/crh.po (+103/-0)
po/cs.po (+103/-0)
po/csb.po (+104/-0)
po/cv.po (+93/-0)
po/cy.po (+105/-0)
po/da.po (+103/-0)
po/de.po (+103/-0)
po/de_DE.po (+93/-0)
po/dv.po (+93/-0)
po/el.po (+102/-0)
po/en.po (+93/-0)
po/en_AU.po (+103/-0)
po/en_CA.po (+103/-0)
po/en_GB.po (+103/-0)
po/eo.po (+102/-0)
po/es.po (+102/-0)
po/et.po (+102/-0)
po/eu.po (+103/-0)
po/fa.po (+101/-0)
po/fa_AF.po (+93/-0)
po/fi.po (+103/-0)
po/fil.po (+97/-0)
po/fo.po (+102/-0)
po/fr.po (+103/-0)
po/fr_CA.po (+93/-0)
po/fur.po (+98/-0)
po/fy.po (+102/-0)
po/ga.po (+98/-0)
po/gd.po (+105/-0)
po/gl.po (+103/-0)
po/gu.po (+97/-0)
po/he.po (+102/-0)
po/hi.po (+102/-0)
po/hr.po (+104/-0)
po/hu.po (+103/-0)
po/hy.po (+93/-0)
po/id.po (+102/-0)
po/is.po (+102/-0)
po/it.po (+103/-0)
po/ja.po (+101/-0)
po/jv.po (+93/-0)
po/ka.po (+101/-0)
po/kk.po (+101/-0)
po/km.po (+101/-0)
po/kn.po (+93/-0)
po/ko.po (+101/-0)
po/ku.po (+100/-0)
po/ky.po (+93/-0)
po/lo.po (+93/-0)
po/lt.po (+103/-0)
po/lv.po (+103/-0)
po/mhr.po (+93/-0)
po/mi.po (+93/-0)
po/mk.po (+99/-0)
po/ml.po (+97/-0)
po/mn.po (+102/-0)
po/mr.po (+97/-0)
po/ms.po (+103/-0)
po/mt.po (+93/-0)
po/my.po (+96/-0)
po/nb.po (+103/-0)
po/nds.po (+102/-0)
po/ne.po (+97/-0)
po/nl.po (+103/-0)
po/nn.po (+103/-0)
po/oc.po (+103/-0)
po/pa.po (+100/-0)
po/pl.po (+104/-0)
po/ps.po (+93/-0)
po/pt.po (+103/-0)
po/pt_BR.po (+103/-0)
po/pt_PT.po (+93/-0)
po/qu.po (+93/-0)
po/ro.po (+104/-0)
po/ru.po (+103/-0)
po/sco.po (+93/-0)
po/sd.po (+93/-0)
po/se.po (+93/-0)
po/shn.po (+93/-0)
po/si.po (+100/-0)
po/sk.po (+103/-0)
po/sl.po (+105/-0)
po/sq.po (+103/-0)
po/sr.po (+103/-0)
po/st.po (+93/-0)
po/sv.po (+103/-0)
po/ta.po (+97/-0)
po/te.po (+102/-0)
po/tg.po (+103/-0)
po/th.po (+101/-0)
po/tl.po (+99/-0)
po/tr.po (+102/-0)
po/ug.po (+101/-0)
po/uk.po (+103/-0)
po/ur.po (+93/-0)
po/uz.po (+99/-0)
po/vi.po (+101/-0)
po/xh.po (+93/-0)
po/zh_CN.po (+101/-0)
po/zh_HK.po (+101/-0)
po/zh_TW.po (+101/-0)
src/Makefile.am (+23/-0)
src/avahi.c (+47/-0)
src/avahi.h (+3/-0)
src/crash.c (+13/-0)
src/hooks.c (+6/-0)
src/livepatch-tray.c (+16/-0)
src/livepatch-utils.c (+4/-0)
src/livepatch-utils.h (+9/-0)
src/system-crash.c (+8/-0)
src/update-notifier.c (+43/-0)
src/update-notifier.h (+16/-0)
src/update.c (+8/-0)
tests/pyflakes.exclude (+4/-0)
tests/test_motd.py (+88/-0)
tests/test_pep8.py (+39/-0)

~chad.smith/ubuntu/+source/update-notifier:xenial-pep-autopkgtest

Merged into ubuntu/+source/update-notifier:ubuntu/xenial-proposed at revision 40b2c4723d76bdc08ad905c799d461a1bc44f758

Christian Ehrhardt  (community): Approve on 2020-12-14

~chad.smith/ubuntu/+source/update-notifier:xenial-esm-product-url-renaming

Merged into ubuntu/+source/update-notifier:ubuntu/xenial-proposed at revision 4a7914638a2f2396dd62a8bface6bf7c17d1b3ac

Christian Ehrhardt  (community): Approve on 2020-12-03

Bryce Harrington: Pending requested 2020-11-19

Chad Smith: Pending requested 2020-11-19

Canonical Server: Pending requested 2020-11-19

git-ubuntu developers: Pending requested 2020-11-19

Diff: 59618 lines (+17062/-15382)

128 files modified

INSTALL (+159/-161)
data/apt_check.py (+37/-31)
data/backend_helper.py (+9/-11)
data/hooks.py (+4/-5)
data/package-data-downloader (+3/-3)
debian/changelog (+21/-0)
debian/control (+1/-0)
po/ace.po (+97/-118)
po/af.po (+161/-131)
po/am.po (+122/-120)
po/an.po (+125/-120)
po/ar.po (+171/-132)
po/ast.po (+160/-131)
po/az.po (+109/-118)
po/be.po (+168/-136)
po/bem.po (+97/-118)
po/bg.po (+160/-130)
po/bn.po (+183/-153)
po/bo.po (+95/-119)
po/br.po (+151/-128)
po/bs.po (+167/-134)
po/ca.po (+161/-130)
po/ca@valencia.po (+161/-130)
po/ckb.po (+125/-124)
po/crh.po (+171/-144)
po/cs.po (+161/-129)
po/csb.po (+160/-129)
po/cv.po (+98/-119)
po/cy.po (+152/-128)
po/da.po (+161/-131)
po/de.po (+164/-133)
po/de_DE.po (+97/-118)
po/dv.po (+95/-119)
po/el.po (+166/-135)
po/en.po (+97/-118)
po/en_AU.po (+159/-129)
po/en_CA.po (+159/-129)
po/en_GB.po (+159/-129)
po/eo.po (+159/-129)
po/es.po (+159/-129)
po/et.po (+161/-131)
po/eu.po (+159/-129)
po/fa.po (+172/-144)
po/fa_AF.po (+95/-119)
po/fi.po (+159/-129)
po/fil.po (+116/-120)
po/fo.po (+160/-130)
po/fr.po (+160/-130)
po/fr_CA.po (+97/-118)
po/fur.po (+137/-128)
po/fy.po (+141/-125)
po/ga.po (+105/-118)
po/gd.po (+171/-138)
po/gl.po (+163/-133)
po/gu.po (+98/-120)
po/he.po (+162/-132)
po/hi.po (+163/-144)
po/hr.po (+169/-140)
po/hu.po (+159/-129)
po/hy.po (+95/-119)
po/id.po (+157/-128)
po/is.po (+160/-131)
po/it.po (+159/-129)
po/ja.po (+190/-147)
po/jv.po (+97/-118)
po/ka.po (+149/-127)
po/kk.po (+156/-128)
po/km.po (+184/-169)
po/kn.po (+103/-118)
po/ko.po (+191/-144)
po/ku.po (+143/-124)
po/ky.po (+95/-119)
po/lo.po (+95/-119)
po/lt.po (+164/-132)
po/lv.po (+161/-130)
po/mhr.po (+117/-120)
po/mi.po (+97/-118)
po/mk.po (+136/-128)
po/ml.po (+113/-124)
po/mn.po (+148/-126)
po/mr.po (+126/-129)
po/ms.po (+163/-133)
po/mt.po (+111/-120)
po/my.po (+137/-124)
po/nb.po (+160/-131)
po/nds.po (+151/-128)
po/ne.po (+97/-118)
po/nl.po (+160/-131)
po/nn.po (+159/-129)
po/oc.po (+160/-131)
po/pa.po (+152/-132)
po/pl.po (+161/-130)
po/ps.po (+97/-118)
po/pt.po (+161/-132)
po/pt_BR.po (+165/-134)
po/pt_PT.po (+100/-118)
po/qu.po (+97/-118)
po/ro.po (+161/-130)
po/ru.po (+164/-133)
po/sco.po (+109/-118)
po/sd.po (+97/-118)
po/se.po (+100/-118)
po/shn.po (+97/-118)
po/si.po (+129/-121)
po/sk.po (+161/-130)
po/sl.po (+166/-132)
po/sq.po (+160/-129)
po/sr.po (+163/-132)
po/st.po (+104/-120)
po/sv.po (+158/-128)
po/ta.po (+124/-123)
po/te.po (+179/-159)
po/tg.po (+164/-134)
po/th.po (+166/-146)
po/tl.po (+121/-124)
po/tr.po (+165/-136)
po/ug.po (+160/-132)
po/uk.po (+164/-133)
po/update-notifier.pot (+50/-16)
po/ur.po (+103/-118)
po/uz.po (+117/-120)
po/vi.po (+158/-131)
po/xh.po (+96/-117)
po/zh_CN.po (+171/-131)
po/zh_HK.po (+173/-132)
po/zh_TW.po (+177/-134)
tests/test_motd.py (+20/-20)
tests/test_package-data-downloader.py (+7/-7)

~chad.smith/ubuntu/+source/update-notifier:bionic-esm-product-url-renaming

Merged into ubuntu/+source/update-notifier:ubuntu/bionic-proposed at revision 12e1ff6004a48d31b688ec1b889e76f0894dabda

Christian Ehrhardt  (community): Approve on 2020-12-02

Bryce Harrington: Pending requested 2020-11-19

Canonical Server: Pending requested 2020-11-19

git-ubuntu developers: Pending requested 2020-11-19

Diff: 62946 lines (+20546/-14592)

129 files modified

INSTALL (+159/-161)
data/apt_check.py (+17/-18)
data/backend_helper.py (+1/-0)
data/hooks.py (+1/-1)
data/package-data-downloader (+2/-2)
debian/changelog (+25/-0)
debian/control (+1/-0)
po/ace.po (+121/-108)
po/af.po (+193/-126)
po/am.po (+153/-114)
po/an.po (+154/-114)
po/ar.po (+207/-127)
po/ast.po (+192/-126)
po/az.po (+137/-111)
po/be.po (+200/-130)
po/bem.po (+121/-108)
po/bg.po (+192/-125)
po/bn.po (+215/-148)
po/bo.po (+118/-109)
po/br.po (+183/-123)
po/bs.po (+199/-128)
po/ca.po (+192/-124)
po/ca@valencia.po (+192/-124)
po/ckb.po (+155/-117)
po/crh.po (+201/-136)
po/cs.po (+194/-124)
po/csb.po (+192/-123)
po/cv.po (+121/-109)
po/cy.po (+183/-122)
po/da.po (+193/-126)
po/de.po (+195/-127)
po/de_DE.po (+123/-110)
po/dv.po (+118/-109)
po/el.po (+197/-129)
po/en.po (+121/-108)
po/en_AU.po (+191/-124)
po/en_CA.po (+191/-124)
po/en_GB.po (+191/-124)
po/eo.po (+191/-124)
po/es.po (+191/-124)
po/et.po (+193/-126)
po/eu.po (+191/-124)
po/fa.po (+203/-139)
po/fa_AF.po (+118/-109)
po/fi.po (+191/-124)
po/fil.po (+144/-113)
po/fo.po (+192/-125)
po/fr.po (+191/-124)
po/fr_CA.po (+121/-108)
po/fur.po (+167/-121)
po/fy.po (+172/-119)
po/ga.po (+134/-111)
po/gd.po (+204/-132)
po/gl.po (+194/-127)
po/gu.po (+122/-110)
po/he.po (+194/-127)
po/hi.po (+195/-139)
po/hr.po (+202/-135)
po/hu.po (+191/-124)
po/hy.po (+118/-109)
po/id.po (+188/-123)
po/is.po (+192/-126)
po/it.po (+191/-124)
po/ja.po (+221/-142)
po/jv.po (+121/-108)
po/ka.po (+180/-122)
po/kk.po (+187/-123)
po/km.po (+215/-164)
po/kn.po (+129/-110)
po/ko.po (+222/-139)
po/ku.po (+175/-119)
po/ky.po (+118/-109)
po/lo.po (+118/-109)
po/lt.po (+196/-126)
po/lv.po (+194/-125)
po/mhr.po (+147/-114)
po/mi.po (+121/-108)
po/mk.po (+166/-121)
po/ml.po (+143/-117)
po/mn.po (+179/-121)
po/mr.po (+156/-122)
po/ms.po (+194/-127)
po/mt.po (+137/-110)
po/my.po (+168/-119)
po/nb.po (+191/-125)
po/nds.po (+183/-123)
po/ne.po (+123/-110)
po/nl.po (+192/-126)
po/nn.po (+191/-124)
po/oc.po (+192/-126)
po/pa.po (+184/-127)
po/pl.po (+193/-124)
po/ps.po (+121/-108)
po/pt.po (+192/-126)
po/pt_BR.po (+196/-128)
po/pt_PT.po (+125/-109)
po/qu.po (+121/-108)
po/ro.po (+194/-125)
po/ru.po (+197/-128)
po/sco.po (+137/-111)
po/sd.po (+126/-110)
po/se.po (+126/-110)
po/shn.po (+121/-108)
po/si.po (+159/-116)
po/sk.po (+194/-125)
po/sl.po (+199/-126)
po/sq.po (+192/-124)
po/sr.po (+195/-126)
po/st.po (+128/-110)
po/sv.po (+190/-123)
po/ta.po (+155/-117)
po/te.po (+212/-155)
po/tg.po (+195/-128)
po/th.po (+197/-141)
po/tl.po (+147/-116)
po/tr.po (+196/-130)
po/ug.po (+191/-127)
po/uk.po (+197/-128)
po/update-notifier.pot (+46/-12)
po/ur.po (+131/-111)
po/uz.po (+146/-113)
po/vi.po (+189/-126)
po/xh.po (+122/-108)
po/zh_CN.po (+202/-126)
po/zh_HK.po (+204/-127)
po/zh_TW.po (+208/-129)
tests/test_motd.py (+20/-22)
tests/test_package-data-downloader.py (+7/-8)
tests/test_pep8.py (+1/-1)

Chad Smith (chad.smith) on 2020-12-02

description:

updated

Chad Smith (chad.smith) on 2020-12-02

summary:	- Resolve autopkgtest failures Pep8 on Xenial and Bionic + Resolve autopkgtest failures Pep8/pyflakes on Xenial and Bionic
description:	updated

Christian Ehrhardt  (paelzer) on 2020-12-02

description:

updated

Revision history for this message

Timo Aaltonen (tjaalton) wrote on 2020-12-04: Please test proposed package

Hello Chad, or anyone else affected,

Accepted update-notifier into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-notifier/3.192.1.9 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in update-notifier (Ubuntu Bionic):
status:	New → Fix Committed
tags:	added: verification-needed verification-needed-bionic

Revision history for this message

Timo Aaltonen (tjaalton) wrote on 2020-12-04:

Hello Chad, or anyone else affected,

Accepted update-notifier into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-notifier/3.168.12 in a few hours, and then in the -proposed repository.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in update-notifier (Ubuntu Xenial):
status:	New → Fix Committed
tags:	added: verification-needed-xenial

Revision history for this message

Ubuntu SRU Bot (ubuntu-sru-bot) wrote on 2020-12-04: Autopkgtest regression report (update-notifier/3.168.12)

All autopkgtests for the newly accepted update-notifier (3.168.12) for xenial have finished running.
The following regressions have been reported in tests triggered by the package:

update-notifier/3.168.12 (ppc64el, amd64, arm64, s390x, armhf, i386)
update-manager/1:16.04.17 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/xenial/update_excuses.html#update-notifier

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Mathew Hodson (mhodson) on 2020-12-11

Changed in update-notifier (Ubuntu):
status:	New → Fix Released

Christian Ehrhardt  (paelzer) on 2020-12-14

description:

updated

Revision history for this message

Timo Aaltonen (tjaalton) wrote on 2020-12-21: Please test proposed package

Hello Chad, or anyone else affected,

Accepted update-notifier into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-notifier/3.168.13 in a few hours, and then in the -proposed repository.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message

Ubuntu SRU Bot (ubuntu-sru-bot) wrote on 2020-12-21: Autopkgtest regression report (update-notifier/3.168.13)

All autopkgtests for the newly accepted update-notifier (3.168.13) for xenial have finished running.
The following regressions have been reported in tests triggered by the package:

update-manager/1:16.04.17 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/xenial/update_excuses.html#update-notifier

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message

Chad Smith (chad.smith) wrote on 2021-01-04:

Xenial and Bionic autopkgtest results now succeed without flake errors
xenial: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/u/update-manager/20201221_145330_55dfc@/log.gz

bionic: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/u/update-manager/20201204_193308_8f594@/log.gz

tags:

added: verification-done verification-done-bionic verification-done-xenial
removed: verification-needed verification-needed-bionic verification-needed-xenial

Chad Smith (chad.smith) on 2021-01-04

tags:

removed: regression-proposed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2021-01-05:

This bug was fixed in the package update-notifier - 3.168.13

---------------
update-notifier (3.168.13) xenial; urgency=medium

  * Fix pep8 autopkgtest failures in the right control file (LP: #1906436)
    - d/control: remove pep8 from Build-Depends as no tests run by
      override_dh_auto_test use pep8.
    - d/tests/control: add pep8 to Depends as it is only used by
      python-based autopkgtests via subprocess in test_motd.py.
    - d/tests/test_package-data-downloader.py: mock subprocess calls to
      apt-helper for expected failure tests to avoid emitting error messages
      to console

update-notifier (3.168.12) xenial; urgency=medium

  * data/apt_check.py: Update UA Infra: ESM product name and doc url
    (LP: #1901627)
    - data/apt_check.py: Update name and URL
    - tests/test_motd.py: adapt unittests to match new behavior
    - po/*.po: translation files with intltool-update -r
  * Fix pep8 autopkgtest failures (LP: 1906436)
    - d/control: add expilicit pep8 build-requires dependency
    - data/apt_check.py: fix over-indent pep8 errors
    - data/apt_check & data/backend_helper: resolve underindent pep8 issues
      backport of 9e0f7ee50 [ Brian Murray ]
    - data/apt_check.py, data/package-data-downloader, tests/test_pep8.py:
      + update the code formating to be not hit W504 warnings,
        change to ignore W503 and be consistent with update-manager.
        [ Andrea Azzarone ]
    - INSTALL, data/hooks.py, tests/test_package-data-downloader.py:
      Fix E117 over-indented pep issues. [ Gianfranco Costamagna ]

update-notifier (3.168.11) xenial; urgency=medium

  [ Julian Andres Klode ]
  * Handle missing cases of LP: #1822340, where we told people ESM is not
    enabled, but not how to enable it.
  * Fix multiple disabled ESM repositories being counted as enabled ones.

  [ Brian Murray ]
  * data/apt_check.py: modify wording and output regarding ESM support.
    (LP: #1842508)

  [ Andreas Hasenack ]
  * data/apt_check.py: Update ESM security pockets names (LP: #1881632)
    - the UbuntuESM pocket was renamed from <distro>-security to
      <distro>-infra-security
    - new origin UbuntuESMApps, with a corresponding pocket of
      <distro>-apps-security

-- Chad Smith <email address hidden> Thu, 10 Dec 2020 14:40:50 -0700

This bug was fixed in the package update-notifier - 3.168.13

---------------
update-notifier (3.168.13) xenial; urgency=medium

update-notifier (3.168.12) xenial; urgency=medium

update-notifier (3.168.11) xenial; urgency=medium

[ Brian Murray ]
  * data/apt_check.py: modify wording and output regarding ESM support.
    (LP: #1842508)

-- Chad Smith <chad.smith@canonical.com>  Thu, 10 Dec 2020 14:40:50 -0700

Changed in update-notifier (Ubuntu Xenial):
status:	Fix Committed → Fix Released

Revision history for this message

Brian Murray (brian-murray) wrote on 2021-01-05: Update Released

The verification of the Stable Release Update for update-notifier has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2021-01-05:

This bug was fixed in the package update-notifier - 3.192.1.9

---------------
update-notifier (3.192.1.9) bionic; urgency=medium

  * data/apt_check.py: Update UA Infra: ESM product name and doc url
    (LP: #1901627)
    - data/apt_check.py: Update name and URL
    - tests/test_motd.py: adapt unittests to match new behavior
    - po/*.po: translation files with intltool-update -r
  * Fix pep8/pyflakes autopkgtest failures (LP: #1906436)
    - d/control: add explicit pep8 build-requires dependency
    - test_motd.py: remove unused imports
    - pyflakes: data/backend_helper fix unittests for unreferenced
      variables
    - data/apt_check & data/backend_helper: resolve underindent pep8 issues
      backport of 9e0f7ee50 [ Brian Murray ]
    - data/apt_check.py, data/package-data-downloader, tests/test_pep8.py:
      + update the code formating to be not hit W504 warnings,
        change to ignore W503 and be consistent with update-manager.
        [ Andrea Azzarone ]
    - INSTALL, data/hooks.py, tests/test_package-data-downloader.py:
      Fix E117 over-indented pep issues. [ Gianfranco Costamagna ]
    - test_motd.py: Remove unused imports [ Julian Andres Klode ]
    - pyflakes: data/backend_helper fix unittests for unreferenced variables

update-notifier (3.192.1.8) bionic; urgency=medium

  [ Brian Murray ]
  * data/apt_check.py: modify wording and output regarding ESM support.
    (LP: #1842508)

-- Chad Smith <email address hidden> Mon, 30 Nov 2020 14:25:35 -0700

This bug was fixed in the package update-notifier - 3.192.1.9

---------------
update-notifier (3.192.1.9) bionic; urgency=medium

* data/apt_check.py: Update UA Infra: ESM product name and doc url
    (LP: #1901627)
    - data/apt_check.py: Update name and URL
    - tests/test_motd.py: adapt unittests to match new behavior
    - po/*.po: translation files with intltool-update -r
  * Fix pep8/pyflakes autopkgtest failures (LP: #1906436)
    - d/control: add explicit pep8 build-requires dependency
    - test_motd.py: remove unused imports
    - pyflakes: data/backend_helper fix unittests for unreferenced
      variables
    - data/apt_check & data/backend_helper: resolve underindent pep8 issues
      backport of 9e0f7ee50 [ Brian Murray ]
    - data/apt_check.py, data/package-data-downloader, tests/test_pep8.py:
      + update the code formating to be not hit W504 warnings,
        change to ignore W503 and be consistent with update-manager.
        [ Andrea Azzarone ]
    - INSTALL, data/hooks.py, tests/test_package-data-downloader.py:
      Fix E117 over-indented pep issues. [ Gianfranco Costamagna ]
    - test_motd.py: Remove unused imports [ Julian Andres Klode ]
    - pyflakes: data/backend_helper fix unittests for unreferenced variables

update-notifier (3.192.1.8) bionic; urgency=medium

[ Brian Murray ]
  * data/apt_check.py: modify wording and output regarding ESM support.
    (LP: #1842508)

-- Chad Smith <chad.smith@canonical.com>  Mon, 30 Nov 2020 14:25:35 -0700

Changed in update-notifier (Ubuntu Bionic):
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.

Ubuntuupdate-notifier package

Resolve autopkgtest failures Pep8/pyflakes on Xenial and Bionic

Bug Description

Related branches

Other bug subscribers

Remote bug watches

Ubuntu
update-notifier package