ZFS revert from grub menu not working.

The attachment "zfs_patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

This is a useful workaround, the fundamental issue is a coreutils issue with dd. I wonder if the coreutils maintainers can figure out why dd has an executable stack.

When I extract my initramfs I see that the size of the dd command is not equal to the size of the dd command provided by coreutils. It is the dd command provided by klibc-utils.
So you might want to tag them as well.

Regards.

I'm closing the zsys task because it is an issue with dd not zsys. For lack of fix in dd we will implement the workaround as a last resort.

Status changed to 'Confirmed' because the bug affects multiple users.

This is the patch from Usarin Heininga applied against Hirsute.

Patch for 20.10.

Patch for Focal.

This bug was fixed in the package zfs-linux - 0.8.4-1ubuntu14

---------------
zfs-linux (0.8.4-1ubuntu14) hirsute; urgency=medium

  [ Didier Roche ]
  [ Jean-Baptiste Lallement ]
  * Generate clone uuid without dd which is flagged as having an executable
    stack. Thanks Usarin Heininga for the patch (LP: #1894329)

 -- Jean-Baptiste Lallement <email address hidden> Mon, 09 Nov 2020 10:25:57 +0100

I have tested the new package on Hirsute. Everything is working now.
Thanks.

Thanks for the confirmation :)

We will backport your patch to previous releases soon.

Hello Usarin, or anyone else affected,

Accepted zfs-linux into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/zfs-linux/0.8.4-1ubuntu11.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Usarin, or anyone else affected,

Accepted zfs-linux into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/zfs-linux/0.8.3-1ubuntu12.6 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

This fixed the bug for me on 20.10 after I updated relevant zfs packages to 0.8.4-1ubuntu11.1 from groovy-proposed.

After the update I installed a random package. Tried to revert to the snapshot created by apt. The package was not on my system. It worked. Then I reverted back the revert. The package was back on my system. Everything seems to work now.

Thank you to everyone involved for the fix!

I installed: zfs-initramfs 0.8.4-1ubuntu11.1 amd64 from groovy-proposed
olivier@bison:~$ sudo apt install zfs-initramfs

I created a new snapshot:
olivier@bison:~$ sudo zsysctl state save -s xfer01

I restarted the laptop and did a revert from xfer01, and the boot was successful

I confirm this fixes the issue for groovy

Yes!

Used the Software Updater to add the groovy-proposed repository.
Selected and installed the ZFS packages (from Software Updater).
Installed a small package (using "apt install") to force a grub update.
Rebooted.

"df -h" showed root mounted on the correct filesystem (instead of the previous, truncated "rpool/ROOT/ubuntu_").

Thank folks!!

The verification of the Stable Release Update for zfs-linux has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package zfs-linux - 0.8.4-1ubuntu11.1

---------------
zfs-linux (0.8.4-1ubuntu11.1) groovy; urgency=medium

  [ Didier Roche ]
  [ Jean-Baptiste Lallement ]
  * Generate clone uuid without dd which is flagged as having an executable
    stack. Thanks Usarin Heininga for the patch (LP: #1894329)

  [ Andrea Righi ]
  * fix potential user-space double free when running "zfs mount -a"
    (LP: #1902588)
    - 4702-Revert-Let-zfs-mount-all-tolerate-in-progress-mounts.patch

 -- Colin Ian King <email address hidden> Mon, 30 Nov 2020 19:00:00 +0000

I tested this out with focal -proposed and don't see any issues. Looks OK to me.

This bug was fixed in the package zfs-linux - 0.8.3-1ubuntu12.6

---------------
zfs-linux (0.8.3-1ubuntu12.6) focal; urgency=medium

  [ Didier Roche ]
  [ Jean-Baptiste Lallement ]
  * Generate clone uuid without dd which is flagged as having an executable
    stack. Thanks Usarin Heininga for the patch (LP: #1894329)

  [ Andrea Righi ]
  * fix potential user-space double free when running "zfs mount -a"
    (LP: #1902588)
    - 4702-Revert-Let-zfs-mount-all-tolerate-in-progress-mounts.patch

 -- Colin Ian King <email address hidden> Mon, 30 Nov 2020 19:00:00 +0000

Does this fix also work for Impish Indri (21.10) because I noticed the same issue but I was not able to fix the issue by manually changing the line within /usr/share/initramfs-tools/scripts/zfs.

Possible duplicate on Impish: https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1959522