Javascript issue on /artefact/file/index.php

Bug #1052429 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Son Nguyen

Bug Description

/artefact/file/index.php
reported for 1.5dev

When editing a file attributes (icon next to delete), it redirects to a new page where you can edit the options. If you click cancel at this new page it shows the following:

[WAR] 71 (lib/errors.php:464) An exception was thrown of class PieformException.
THIS IS BAD and should be changed to something extending MaharaException,
unless the exception is from a third party library.
Original trace follows
[WAR] 71 (lib/pieforms/pieform.php:528) No function registered to handle form submission for form "files"
Call stack (most recent first):
Pieform->__construct(array(size 12)) at /home/hugh/src/mahara/mahara/htdocs/lib/pieforms/pieform.php:161
Pieform::process(array(size 12)) at /home/hugh/src/mahara/mahara/htdocs/lib/pieforms/pieform.php:71
pieform(array(size 12)) at /home/hugh/src/mahara/mahara/htdocs/artefact/file/index.php:38

The url is /artefact/file/index.php?edit=32

Tags: javascript
Changed in mahara:
assignee: nobody → Son Nguyen (ngson2000)
milestone: none → 1.7.0
tags: added: javascript
Changed in mahara:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Son Nguyen (ngson2000) wrote :

There are more Javascript issues on this page:
 - Enter a folder name and press <Enter> key (insteads of click 'Create folder' button), the system wrongly assumes the button 'Upload' is clicked.
 - Drag and drop function for moving file/folder does not work
 - The link 'Show my tags' disappears
 - Click 'Edit' button, Empty the required field 'Name', then click 'Save changes' will get a wrong error message: "The file field is required", and the form for editting file is closed.

 - No confirmation box appears when deleting a file which is in pages or when deleting a non-empty folder

Revision history for this message
Son Nguyen (ngson2000) wrote :

These issues also happen on /artefact/file/groupfiles.php

Revision history for this message
Son Nguyen (ngson2000) wrote :

These issues also happen on /artefact/file/institutionfiles.php
These issues also happen on /artefact/file/sitefiles.php

Revision history for this message
Son Nguyen (ngson2000) wrote :
Son Nguyen (ngson2000)
Changed in mahara:
status: Triaged → In Progress
Revision history for this message
Son Nguyen (ngson2000) wrote :

Test cases

To access the page /artefact/file/
1. Login as an user
2. On the main menu, click Portfolio/Files
3. If you dont have a file, upload one
4. If you dont have a directory, create one

To access the page /artefact/file/groupfiles.php
1. Login as an user
2. On the main menu, click Groups/My groups
3. If you dont have a group, create one
4. Click the title of a group
5. Click the tab 'Files'

To access the page /artefact/file/institutionfiles.php
1. Login as an institution or site admin
2. On the main menu, click Institutions/Files

To access the page /artefact/file/sitefiles.php
1. Login as a site admin
2. On the main menu, click Configure/Files

Make sure all information are correct and buttons work properly.

Revision history for this message
Melissa Draper (melissa) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 milestone 1.8
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iQIcBAEBAgAGBQJRIwvSAAoJEJHQT0Mtn5aHiTAQAMvv3UB+Std5sp7MNLJisIWM
F3w5pbCldLn86j6IA8nIGNAqebAOLiQ3AW3a5zO1LZ3lHy3Yp8En4sIPSOkF2U8L
6U/DF9pDo/z7cuo+GhtlgRe7oUyklpWNjgsF4/yw8ppYLuQ6eLgQiopyuZX6N7+a
NTQfXknHZIIEe4XhWmV2b9GGVF4Mhg1RUshsJe5/FvvC9ybXV+TTL/8HfFcdVL8e
lJfqu6Kjf4ueyp5dUXtHkh+GArjmT+O6j+bFRgR9rpvS4140JZimj05ZvjWzb6oS
zYgtyNap/T0rcyZP/upNweEhaWGAdJAMoO+GOIcSMDgTdWaAXyLlEgVfFOhx2IhT
sH6Dfuld4bCRsRLcrQwpKwcOB9xEYleCAXSeaZsVry9rfj2LWcrXzrBhPDsa7JQ0
qcPzymGh8kHHpVJPuaX3ztyaKPdS4jP8mz6CGnTwZ2ot2dDbbMBal4fkZfQ4j/cR
j1V9Q6HBU9RkcjXvcGFvYyA9HPMPVETQyx9mu/KYVtGf88Y9ucLlflQDsPskhZdQ
H8l9vEzdJLURAyq/YXKdrR14g9OgA+aqIWIO2E1YhjSO2kUAMBeRFjU/FEhftxPw
DkoR86wtix4QHeStPaA9PyPA1X825tdRQ9itqpBqbIgkKpD1Ue6hzf0aOvKX8+FJ
NSqftjUQEqadBbaQTqkP
=t4IF
-----END PGP SIGNATURE-----

Son Nguyen (ngson2000)
Changed in mahara:
milestone: 1.7.0 → 1.8.0
Robert Lyon (robertl-9)
Changed in mahara:
importance: High → Medium
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/1745
Committed: http://gitorious.org/mahara/mahara/commit/5031431b4b47c1fdb7a697365a2e2bb9d92c3974
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5031431b4b47c1fdb7a697365a2e2bb9d92c3974
Author: Son Nguyen <email address hidden>
Date: Thu Oct 4 09:04:11 2012 +1300

Redirect to /artefact/file/ when click Cancel (bug #1052429)

In non-js web browser, the pieform of filebrowser will be submitted when
click 'Cancel' button. Handle this action by redirect to
/artefact/file/index.php

Change-Id: If32385105f8c705be08ae70fa00bc9583f0227a1
Signed-off-by: Son Nguyen <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Aaron Wells (u-aaronw)
Changed in mahara:
milestone: 1.8rc1 → 1.8.0
Aaron Wells (u-aaronw)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.