LAVA Dashboard (deprecated)

Merge lp:~stevanr/lava-dashboard/fix-1198195 into lp:lava-dashboard

  1. fix-1198195
  2. Merge into trunk
Proposed by Stevan Radaković
Status: Merged
Approved by: Senthil Kumaran S
Approved revision: 415
Merged at revision: 414
Proposed branch: lp:~stevanr/lava-dashboard/fix-1198195
Merge into: lp:lava-dashboard
Diff against target: 34 lines (+6/-4)
1 file modified
dashboard_app/static/dashboard_app/js/image-report.js (+6/-4)
To merge this branch: bzr merge lp:~stevanr/lava-dashboard/fix-1198195
Reviewer Review Type Date Requested Status
Senthil Kumaran S Approve
Linaro Automation & Validation Pending
Review via email: mp+180119@code.launchpad.net

Description of the change

Fix bug #1198195.
Remove storing of end build number.
Add default behavior for start build number to be end number minus 15.

To post a comment you must log in.
Revision history for this message
Senthil Kumaran S (stylesen) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dashboard_app/static/dashboard_app/js/image-report.js'
2--- dashboard_app/static/dashboard_app/js/image-report.js 2013-07-25 13:57:18 +0000
3+++ dashboard_app/static/dashboard_app/js/image-report.js 2013-08-14 12:27:24 +0000
4@@ -43,6 +43,12 @@
5 text: build_number
6 }));
7 }
8+ start_number_options = $("#build_number_start option").size();
9+ // Show last 15 options.
10+ if (start_number_options > 15) {
11+ start_number_options -= 15;
12+ $("#build_number_start option:eq(" + start_number_options + ")").attr("selected", true);
13+ }
14 $("#build_number_end option:last").attr("selected", true);
15
16 for (iter in test_run_names) {
17@@ -202,7 +208,6 @@
18
19 $.jStorage.set(prefix + "_target_goal", $("#target_goal").val().trim());
20 $.jStorage.set(prefix + "_build_number_start", $("#build_number_start").val());
21- $.jStorage.set(prefix + "_build_number_end", $("#build_number_end").val());
22 $.jStorage.set(prefix + "_test_select", $("#test_select").val());
23 $.jStorage.set(prefix + "_toggle_graph", $("#toggle_graph").attr("checked"));
24 $.jStorage.set(prefix + "_graph_type", $('input:radio[name=graph_type]:checked').val());
25@@ -225,9 +230,6 @@
26 if ($.jStorage.get(prefix + "_build_number_start")) {
27 $("#build_number_start").val($.jStorage.get(prefix + "_build_number_start"));
28 }
29- if ($.jStorage.get(prefix + "_build_number_end")) {
30- $("#build_number_end").val($.jStorage.get(prefix + "_build_number_end"));
31- }
32 if ($.jStorage.get(prefix + "_test_select")) {
33 $("#test_select").val($.jStorage.get(prefix + "_test_select"));
34 }

Subscribers

People subscribed via source and target branches