Merge lp:~sil2100/autopilot/u-a-l-2_nbs_removal into lp:autopilot

Looks good to me

FAILED: Autolanding.
More details in the following jenkins job:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-autoland/18/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/594/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/591/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-land-mp/2844/console

The tests are failing as they're being run against the xenial main archive. Xenial has an obsolete ubuntu-app-launch version that still uses the old ABI package - the xenial-overlay has the latest one.

Are there any reasons why the tests still run against xenial instead of zesty? I suppose that trunk == latest development release, so we should be using zesty for running tests. Especially that we want to get rid of gir1.2-ubuntu-app-launch-2 from that series.

We're working on making the ci update to zesty now.

FAILED: Autolanding.
More details in the following jenkins job:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-autoland/19/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-zesty-amd64-package/2/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-zesty-i386-package/2/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-land-mp/2846/console

FAILED: Autolanding.
More details in the following jenkins job:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-autoland/20/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-zesty-amd64-package/3/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-zesty-i386-package/3/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-land-mp/2847/console

The package build are on zesty, but there are still some failures

This is what's showing on i386:
   debian/rules override_dh_auto_test
make[1]: Entering directory '/build/autopilot-1.6.0+16.10.20160818.1'
HOME=`mktemp -d --tmpdir=debian` \
XDG_RUNTIME_DIR=`mktemp -d --tmpdir=debian` \
python3 -m testtools.run discover autopilot.tests.unit
/usr/lib/python3.5/runpy.py:125: RuntimeWarning: 'testtools.run' found in sys.modules after import of package 'testtools', but prior to execution of 'testtools.run'; this may result in unpredictable behaviour
  warn(RuntimeWarning(msg))

terminate called after throwing an instance of 'std::runtime_error'
  what(): Unable to connect to user bus: Cannot autolaunch D-Bus without X11 $DISPLAY
Aborted (core dumped)
debian/rules:23: recipe for target 'override_dh_auto_test' failed
make[1]: *** [override_dh_auto_test] Error 134
make[1]: Leaving directory '/build/autopilot-1.6.0+16.10.20160818.1'
debian/rules:8: recipe for target 'build' failed
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2

FAILED: Continuous integration, rev:594
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/178/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-zesty-amd64-package/6/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-zesty-i386-package/6/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/2282/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/178/rebuild

The build failure is unrelated to this change, I think we need to poke around as something in zesty broke the build. I checked this by performing a no-change rebuild of autopilot in a PPA and got the same build failure.

Eh, bad luck...

I filled in a bug for this: https://bugs.launchpad.net/ubuntu/+source/autopilot/+bug/1679574

I now have a separate mp to fix the zesty package building here: https://code.launchpad.net/~canonical-platform-qa/autopilot/fix-zesty-build/+merge/321891