Merge lp:~openerp-dev/openobject-server/trunk-opw-576860-port-kbh into lp:openobject-server

Proposed by Khushboo Bhatt(openerp)
Status: Needs review
Proposed branch: lp:~openerp-dev/openobject-server/trunk-opw-576860-port-kbh
Merge into: lp:openobject-server
Diff against target: 12 lines (+2/-0)
1 file modified
openerp/report/render/rml2pdf/trml2pdf.py (+2/-0)
To merge this branch: bzr merge lp:~openerp-dev/openobject-server/trunk-opw-576860-port-kbh
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+138635@code.launchpad.net

Description of the change

Rapports written using rml now allows blank lines in user text.

Steps to reproduce the bug:
* install the module account_followup
* enter text with spaces between lines
* print the followup => blank lines are not printed

This change should impact every modules using trml2pdf

Code is forward port from 6.1
Thanks,
Khushboo.

To post a comment you must log in.
Revision history for this message
Olivier Laurent (Acsone) (olivier-laurent) wrote :

Hello,

Until today, it seems this fix:
- is not yet merged within 6.1 nor 7.0 branches
- has no effect with the version 2.6 of the reportlab library.

What is the real status/future of this fix/MP ?

Thanks,
Olivier LAURENT

Unmerged revisions

4645. By <email address hidden>

[FIX]double line breaks where not printed, cannot make spaces in a text without modifying the rml template

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openerp/report/render/rml2pdf/trml2pdf.py'
2--- openerp/report/render/rml2pdf/trml2pdf.py 2012-11-26 18:15:27 +0000
3+++ openerp/report/render/rml2pdf/trml2pdf.py 2012-12-07 05:34:20 +0000
4@@ -743,6 +743,8 @@
5 style.__dict__.update(extra_style)
6 result = []
7 for i in self._textual(node).split('\n'):
8+ if len(i.strip()) == 0:
9+ i = '<font color="white"> </font>'
10 result.append(platypus.Paragraph(i, style, **(utils.attr_get(node, [], {'bulletText':'str'}))))
11 return result
12 elif node.tag=='barCode':