Merge lp:~jeremywootten/pantheon-files/drag-tab-to-new-window into lp:~elementary-apps/pantheon-files/trunk
Proposed by
Jeremy Wootten
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Danielle Foré | ||||||||
Approved revision: | 1970 | ||||||||
Merged at revision: | 2121 | ||||||||
Proposed branch: | lp:~jeremywootten/pantheon-files/drag-tab-to-new-window | ||||||||
Merge into: | lp:~elementary-apps/pantheon-files/trunk | ||||||||
Diff against target: |
371 lines (+162/-51) 4 files modified
src/Application.vala (+81/-26) src/QuicklistHandler.vala (+1/-1) src/View/Sidebar.vala (+1/-1) src/View/Window.vala (+79/-23) |
||||||||
To merge this branch: | bzr merge lp:~jeremywootten/pantheon-files/drag-tab-to-new-window | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Danielle Foré | ux | Approve | |
Review via email: mp+291111@code.launchpad.net |
Commit message
Form new windows by dragging tabs; limit rate and number of new windows.
Description of the change
This branch addresses some issues around window creation.
1) Implement forming new windows by dragging tabs out of the window. The window is created where dropped.
2) A limit is put on the rate of window creation using the keyboard (Ctrl-N).
3) Only one function in Application is now allowed to create windows.
To post a comment you must log in.
I think your idea about hiding the sidebar on new windows makes sense, but you've introduced an issue where if you close that first window it's impossible to get the sidebar back. Even killing everything and resetting the dconf key, I can't get the sidebar back. We should probably enforce that if you close the "main window" the sidebar will show on one of the other windows.
If I hold down Ctrl N, after the 3rd window everything crashes