Evernote Online Accounts plugin

Merge lp:~dpm/account-plugin-evernote/sandbox-notice into lp:account-plugin-evernote

  1. sandbox-notice
  2. Merge into trunk
Proposed by David Planella
Status: Merged
Approved by: Chris Wayne
Approved revision: 12
Merged at revision: 12
Proposed branch: lp:~dpm/account-plugin-evernote/sandbox-notice
Merge into: lp:account-plugin-evernote
Diff against target: 38 lines (+5/-5)
3 files modified
data/providers/evernote.provider.in (+1/-1)
data/services/evernote.service.in (+1/-1)
debian/control (+3/-3)
To merge this branch: bzr merge lp:~dpm/account-plugin-evernote/sandbox-notice
Reviewer Review Type Date Requested Status
Chris Wayne Approve
PS Jenkins bot continuous-integration Approve
Michael Zanetti (community) Approve
Review via email: mp+201165@code.launchpad.net

Description of the change

Simply changed the description text of the account and in the .deb package description to made it clear that its purpose is to access developer accounts, and not regular Evernote ones.

To post a comment you must log in.
Revision history for this message
Michael Zanetti (mzanetti) wrote :

lgtm

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:12
http://jenkins.qa.ubuntu.com/job/account-plugin-evernote-ci/1/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-plugin-evernote-trusty-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/account-plugin-evernote-trusty-armhf-ci/1
        deb: http://jenkins.qa.ubuntu.com/job/account-plugin-evernote-trusty-armhf-ci/1/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/account-plugin-evernote-ci/1/rebuild

review: Approve (continuous-integration)
Revision history for this message
Chris Wayne (cwayne) wrote :

Looks reasonable. I imagine once this is released it will be changed back?

review: Approve
Revision history for this message
David Planella (dpm) wrote :

Yes, we'll change it also to point to evernote.com instead of sandbox.evernote.com once we get review and approval from Evernote.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/providers/evernote.provider.in'
2--- data/providers/evernote.provider.in 2013-11-14 03:39:10 +0000
3+++ data/providers/evernote.provider.in 2014-01-10 11:58:29 +0000
4@@ -1,6 +1,6 @@
5 <?xml version="1.0" encoding="UTF-8"?>
6 <provider id="evernote">
7- <name>Evernote</name>
8+ <name>Evernote Developer Sandbox</name>
9 <icon>evernote</icon>
10 <translations>account-plugins</translations>
11 <plugin>generic-oauth</plugin>
12
13=== modified file 'data/services/evernote.service.in'
14--- data/services/evernote.service.in 2013-11-14 03:39:10 +0000
15+++ data/services/evernote.service.in 2014-01-10 11:58:29 +0000
16@@ -1,7 +1,7 @@
17 <?xml version="1.0" encoding="UTF-8"?>
18 <service id="evernote-publish">
19 <type>sharing</type>
20- <name>Evernote</name>
21+ <name>Evernote Developer Sandbox</name>
22 <icon>evernote</icon>
23 <provider>evernote</provider>
24 <translations>account-plugins</translations>
25
26=== modified file 'debian/control'
27--- debian/control 2013-12-13 18:12:21 +0000
28+++ debian/control 2014-01-10 11:58:29 +0000
29@@ -21,6 +21,6 @@
30 Depends: libaccount-plugin-generic-oauth,
31 qtdeclarative5-online-accounts-client0.1,
32 ${misc:Depends},
33-Description: Allow Ubuntu to access Evernote
34- This plugin allows the user to authenticate to their Evernote account, which
35- allows syncing of Evernote notes across Ubuntu devies.
36+Description: Allow Ubuntu to access the Evernote developer sandbox
37+ This plugin enables developers to authenticate to their Evernote developer
38+ sanbox account, which allows syncing of Evernote notes across Ubuntu devices.

Subscribers

People subscribed via source and target branches