Linaro Android Build Tools

Merge lp:~deeptik/linaro-android-build-tools/source_overlay_check into lp:linaro-android-build-tools

  1. source_overlay_check
  2. Merge into trunk
Proposed by Deepti B. Kalakeri
Status: Merged
Approved by: Georgy Redkozubov
Approved revision: 543
Merged at revision: 545
Proposed branch: lp:~deeptik/linaro-android-build-tools/source_overlay_check
Merge into: lp:linaro-android-build-tools
Diff against target: 16 lines (+6/-0)
1 file modified
build-scripts/build-android (+6/-0)
To merge this branch: bzr merge lp:~deeptik/linaro-android-build-tools/source_overlay_check
Reviewer Review Type Date Requested Status
Georgy Redkozubov Approve
Milo Casagrande (community) Approve
Review via email: mp+140632@code.launchpad.net

Description of the change

Adding check for presence of SOURCE_OVERLAY in the configuration for the android builds.
With this check introduced the builds should exit if the SOURCE_OVERLAY is not part of the configuration and should pass to completion otherwise. Here are the following builds which check the SOURCE_OVERLAY check for the behaviour respectively for failure on non-exisitence of SOURCE_OVERLAY and success when it exists.
https://ec2-23-20-244-116.compute-1.amazonaws.com/jenkins/job/deepti_without_source_overlay_galaxynexus-jb-gcc44-aosp-stable-blob/1/console
https://ec2-23-20-244-116.compute-1.amazonaws.com/jenkins/job/deepti_linaro-android_panda-ics-gcc47-tilt-tracking-blob/1/console

To post a comment you must log in.
Revision history for this message
Milo Casagrande (milo) wrote :

Looks good to me.
+1

review: Approve
Revision history for this message
Georgy Redkozubov (gesha) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'build-scripts/build-android'
2--- build-scripts/build-android 2012-12-06 15:02:32 +0000
3+++ build-scripts/build-android 2012-12-19 11:31:19 +0000
4@@ -8,6 +8,12 @@
5
6 set -o errtrace
7
8+if [ ! -n "$SOURCE_OVERLAY" ];
9+then
10+ echo "ERROR: Missing SOURCE_OVERLAY in the configuration."
11+ exit 1
12+fi
13+
14 source "${BUILD_SCRIPT_ROOT}"/helpers
15
16 trap infrastructure_error ERR

Subscribers

People subscribed via source and target branches