Merge lp:~bac/charmworld/beaker-namespace into lp:charmworld

Proposed by Brad Crittenden
Status: Merged
Approved by: Brad Crittenden
Approved revision: 513
Merged at revision: 514
Proposed branch: lp:~bac/charmworld/beaker-namespace
Merge into: lp:charmworld
Diff against target: 12 lines (+0/-2)
1 file modified
setup.py (+0/-2)
To merge this branch: bzr merge lp:~bac/charmworld/beaker-namespace
Reviewer Review Type Date Requested Status
Juju Gui Bot continuous-integration Approve
Charmworld Developers Pending
Review via email: mp+220321@code.launchpad.net

Commit message

Remove mongo-beaker from setup.py.

This bit of configuration causes beaker to try to load the mongo backend
twice, generating confusing error messages in app-exception.log.

https://codereview.appspot.com/95480044/

R=rharding

Description of the change

Remove mongo-beaker from setup.py.

This bit of configuration causes beaker to try to load the mongo backend
twice, generating confusing error messages in app-exception.log.

https://codereview.appspot.com/95480044/

To post a comment you must log in.
Revision history for this message
Brad Crittenden (bac) wrote :

Reviewers: mp+220321_code.launchpad.net,

Message:
Please take a look.

Description:
Remove mongo-beaker from setup.py.

This bit of configuration causes beaker to try to load the mongo backend
twice, generating confusing error messages in app-exception.log.

https://code.launchpad.net/~bac/charmworld/beaker-namespace/+merge/220321

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/95480044/

Affected files (+2, -2 lines):
   A [revision details]
   M setup.py

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: tarmac-20140520144639-2wypg2q2m2qwvjch
+New revision: <email address hidden>

Index: setup.py
=== modified file 'setup.py'
--- setup.py 2013-11-18 20:38:47 +0000
+++ setup.py 2014-05-20 18:42:14 +0000
@@ -42,8 +42,6 @@
        remove-start-time-entry = \
          charmworld.scripts.remove_server_start_time:entry_point
        remove-charm = charmworld.scripts.remove_charm:entry_point
- [beaker.backends]
- mongodb = mongodb_beaker:MongoDBNamespaceManager
        """,
        paster_plugins=['pyramid'],
        )

Revision history for this message
Richard Harding (rharding) wrote :

LGTM, it appears we configure from the ini file anyway so this appears
to be unused.

https://codereview.appspot.com/95480044/

Revision history for this message
Brad Crittenden (bac) wrote :

Not unused but actively bad. Thanks for the review.

https://codereview.appspot.com/95480044/

Revision history for this message
Juju Gui Bot (juju-gui-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2013-11-18 20:38:47 +0000
3+++ setup.py 2014-05-20 19:10:06 +0000
4@@ -42,8 +42,6 @@
5 remove-start-time-entry = \
6 charmworld.scripts.remove_server_start_time:entry_point
7 remove-charm = charmworld.scripts.remove_charm:entry_point
8- [beaker.backends]
9- mongodb = mongodb_beaker:MongoDBNamespaceManager
10 """,
11 paster_plugins=['pyramid'],
12 )

Subscribers

People subscribed via source and target branches

to all changes: