Merge lp:~alextu/savilerow/6-pinned-apps into lp:savilerow
Proposed by
Alex Tu
Status: | Merged |
---|---|
Merged at revision: | 12 |
Proposed branch: | lp:~alextu/savilerow/6-pinned-apps |
Merge into: | lp:savilerow |
Diff against target: |
40 lines (+18/-0) 2 files modified
src/system/custom/etc/dconf_source/db/custom.d/custom.key (+5/-0) tests/api/test_dconf.py (+13/-0) |
To merge this branch: | bzr merge lp:~alextu/savilerow/6-pinned-apps |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Chris Wayne (community) | Approve | ||
Alex Tu (community) | Approve | ||
Review via email: mp+228455@code.launchpad.net |
Description of the change
1. add the key com/canonical/
2. add a test script for check if the setting of 6 pinned apps in Apps scope is correct.
Currently it tests
1. If the key and value has been set in custom.key, and it must been set.
2. If the value have 6 items, it must have 6 items.
To post a comment you must log in.
Why is there a whole new test script added? It looks very similar to the current test_dconf test, which should in fact pick up this change anyway without needing to add any tests