Merge lp:~ahayzen/ubuntu-weather-app/fix-1542767-bounce-never-stop into lp:ubuntu-weather-app
Proposed by
Andrew Hayzen
Status: | Merged |
---|---|
Approved by: | Andrew Hayzen |
Approved revision: | 270 |
Merged at revision: | 270 |
Proposed branch: | lp:~ahayzen/ubuntu-weather-app/fix-1542767-bounce-never-stop |
Merge into: | lp:ubuntu-weather-app |
Diff against target: |
79 lines (+24/-7) 3 files modified
app/components/LoadingIndicator.qml (+1/-7) app/ubuntu-weather-app.qml (+7/-0) app/ui/HomePage.qml (+16/-0) |
To merge this branch: | bzr merge lp:~ahayzen/ubuntu-weather-app/fix-1542767-bounce-never-stop |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Sheldon (community) | Approve | ||
Jenkins Bot | continuous-integration | Approve | |
Ubuntu Weather Developers | Pending | ||
Review via email: mp+322758@code.launchpad.net |
Commit message
* Fix bounce bar not stopping when detect location is off and there are no locations
* Force bottom edge to use mouse style
* Fix bounce bar positioning so bottom edge doesn't cover it
Description of the change
* Fix bounce bar not stopping when detect location is off and there are no locations
* Force bottom edge to use mouse style
* Fix bounce bar positioning so bottom edge doesn't cover it
TESTING:
1) Remove all your locations
2) Turn off detect location
3) Notice that the bounce animation at the bottom is not shown (before it was)
To post a comment you must log in.
PASSED: Continuous integration, rev:270 /core-apps- jenkins. ubuntu. com/job/ weather- app-ci/ 82/ /core-apps- jenkins. ubuntu. com/job/ generic- update- mp/1049/ console
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild: /core-apps- jenkins. ubuntu. com/job/ weather- app-ci/ 82/rebuild
https:/