adopt docker-py 2.0 api
As docker-py 2.0 has changed the client.Client to client.
This BP propose to adopt the docker-py 2.0 api in zun.
Refer to:
https:/
https:/
http://
https:/
UPDATE:
* Upgrade to docker 2.0 (DONE)
* Change to client.DockerClient (TBD)
Blueprint information
- Status:
- Complete
- Approver:
- hongbin
- Priority:
- Not
- Drafter:
- Shunli Zhou
- Direction:
- Needs approval
- Assignee:
- None
- Definition:
- Obsolete
- Series goal:
- None
- Implementation:
-
Unknown
- Milestone target:
- None
- Started by
- Completed by
- hongbin
Related branches
Related bugs
| Bug #1671874: Move from docker-py to docker | Fix Released |
| Bug #1693425: Cannot import docker client | Fix Released |
Sprints
Whiteboard
Seems all docker related openstack projects uses the docker-py client, which latest version is 1.10.6. So there is no need to change to 'docker' client which support 2.0 API.
Alternatives is we keep this BP low priority to tracker the 2.0 API progress.
[shu-mutou]
I found that Magnum uses docker>=2.0.0 as follow: https:/
So if we try to start devstack with Magnum and Zun, installed docker-py==1.10.6 is overwritten by docker==2.3.0 for now. Due to above, I got error to load docker.
Seeing following commit for Magnum, it seems not bad to bump up to 2.x.x.
https:/
https:/
[hongbin]
I see. I will increase the priority of the BP and find sometimes to work on it.
[hongbin]
We bump the requirements to docker>=2.0.0 already, and has migrated from client.Client to client.APIClient. An optional follow-up is to migrate from client.APIClient to client.DockerClient .
Gerrit topic: https:/
Addressed by: https:/
[WIP] Upgrade from docker-py to docker
Addressed by: https:/
Fix another upgrade from docker-py to docker place
