Comment 7 for bug 942955

Revision history for this message
Bartosz Kosiorek (gang65) wrote :

I look at your code and here is my remarks:
1. Line 335:
  char buffer[INET6_ADDRSTRLEN];
use nih_local. It shoul looks like:
  nih_local char buffer[INET6_ADDRSTRLEN];

2. Line 72, 73
  Add comment with description of the variables sin6_addr and sin_addr

3. Line 539-546
  Fix identation. You could follow Coding style section in HACKING file

4. Update ChangeLog file

5. Update man files (with additional examples of the IPv6 usage) in directory: extra/man/