Comment 21 for bug 903752

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Ok, finally having the time to look at it, here is my feedback:
- apparmor profile will greatly be appreciated (if not done already),
- dropping semanage buil-dep and using --without-semanage would be appreciated seeing the implication of it and the new build-dep it introduces having compiler warnings.
- for the remaining build-dep (as the tevent discussion was sorted), I would appreciated pointers to MIR bugs (with the full rationale, build-dep check, quality package check) for the 3 others introduced build-dep in main:
* ding-libs (libcollection-dev, libini-config-dev, libdhash-dev)
* tevent (libtevent-dev)
* ldb (libldb-dev)

Please, reassign to me once done :)