Comment 5 for bug 88986

Hi!

I really liked your solution of the mppe-optional patch.
But I modified it to work with the mppc patch applied source (i.e. ppp-2.4.x-mppe-mppc-1.1.patch and linux-2.6.2x-mppc.patch).
Was nothing special, just adjusting a few line differences and so.
The main reason for that was, that OSX (since a few versions) does not connect to pptpd with mppe if mppe is set as an option, even this works flawlessly on windows clients.
Yes, you read right, the mppc patched version of pppd has mppe set to optionally if not requested otherwise in the options file.. .
So, with your patch I can use mppe required in the options file, but it's just optionally, and also behaves right for OSX.

The only Problem is, I can't get it to work with MPPC only (so MPPC withput MPPE). Which works when I don't use the mppe required option, but then I can't use it on OSX. The connection just gets dropped without an error message in the case of an MPPC but not MPPE requesting client.

As I'm not good enough at the debugging, possibly you are able to find a solution for that problem(s)?

Also I noticed, that both version (mppc enabled code or not, but mppc has to be disabled on the windows client) give an error when connection with mppe set as optionally instead of requested or disabled.

So it seems that the code really needs some corrections.

Thank you

Alex