Comment 3 for bug 2033422

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the contribution, Adrien.

I find the naming scheme you chose for the patches a bit confusing. For example, you're using the prefix "jammy-sru-0001-" on several patches that are actually not strictly related. You also don't mention any patch explicitly in the d/changelog entry, which forces the reader to open d/p/series and look at the comments there. Moreover, the patches are missing DEP-3 headers (which, in this case, would be very useful when trying to understand the context when looking at a single patch).

Could you please address the concerns above before we proceed with the upload?

Thanks.