Comment 4 for bug 1689963

Revision history for this message
Christian Seiler (christian-w) wrote :

Hi,

I'm one of the Debian Maintainers of open-isns and I just saw this bug here because I saw the upstream pull request for the fixes to the test suite. First of all: thanks for improving the package. The main reason I've packaged that is because it was split out of open-iscsi, and I'm not really a user of iSNS itself.

I would like to keep any diff between Debian and Ubuntu to a minimum - ideally there'd be no diff at all. I'd also be happy to include any Ubuntu-specific changes in the upstream Debian package. The upstream test suite you've added to DEP-8 appears to be something that would also be useful to run in Debian. If it's OK with you I'd like to review the changes you made in this regard and include them in the Debian package itself.

Apart from that: a short comment on what you wrote in the "Quality Assurance" part of this report:

> * No debconf questions are asked during installation.

This is not entirely true: no debconf questions are asked when installing the library packages themselves in the current Debian package, but because how the software works, the discovery daemon (pkg:open-isns-discoveryd) and the server itself (pkg:open-isns-server) will indeed ask debconf questions on installation and removal. That said: if you have any ideas how to handle that without debconf questions, I'd be open to hearing that. (In Debian we're now at the beginning of the next release cycle, so it'd be no problem at all to change the behavior.)

Regards,
Christian