My last change didn't fix anything because the 'ln' didn't cause the script to fail (the initscript does not use the recommended '#!/bin/sh -e' which through me.
The problem is that in pbuilder and presumably the buildd's, /sysfs is mounted. This allows open-iscsi to continue trying to start itself, and we end up with:
start-stop-daemon ends up returning non-zero, and at the end of the script we have:
exit $RETVAL
One way to fix this would be to use a /etc/default/open-iscsi file that is read by the initscript. (eg 'START_DEVICES=no' is the default, and the script only continues if 'START_DEVICES=yes'). I do not know the ramifications of that for the installer, etc, so I am not going to make that change.
My last change didn't fix anything because the 'ln' didn't cause the script to fail (the initscript does not use the recommended '#!/bin/sh -e' which through me.
The problem is that in pbuilder and presumably the buildd's, /sysfs is mounted. This allows open-iscsi to continue trying to start itself, and we end up with:
start-stop-daemon ends up returning non-zero, and at the end of the script we have:
exit $RETVAL
One way to fix this would be to use a /etc/default/ open-iscsi file that is read by the initscript. (eg 'START_DEVICES=no' is the default, and the script only continues if 'START_ DEVICES= yes'). I do not know the ramifications of that for the installer, etc, so I am not going to make that change.