Comment 5 for bug 1018456

Revision history for this message
Stefan Bader (smb) wrote :

Bisection complete. Bad commit:

commit a1c7fff7e18f59e684e07b0f9a770561cd39f395
Author: Eric Dumazet <email address hidden>
Date: Thu May 17 07:34:16 2012 +0000

    net: netdev_alloc_skb() use build_skb()

    netdev_alloc_skb() is used by networks driver in their RX path to
    allocate an skb to receive an incoming frame.

    With recent skb->head_frag infrastructure, it makes sense to change
    netdev_alloc_skb() to use build_skb() and a frag allocator.

    This permits a zero copy splice(socket->pipe), and better GRO or TCP
    coalescing.

    Signed-off-by: Eric Dumazet <email address hidden>
    Signed-off-by: David S. Miller <email address hidden>

Though it does not seem to be simple revert to test this against current master. It seems there should be a way for the driver to enforce the old style somehow...