Comment 8 for bug 1077484

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

MIR review:
 * Builds fine with just main
 * Interestingly, though it is a unit testing framework for C, it doesn't seem to include a test suite
 * no Ubuntu delta
 * FYI, it's a library but neither ships a symbols file nor uses dh_makeshlibs -V
 * It has a watch file
 * Update history is very slow
 * The latest release is packaged
 * lintian checks are fine
 * debian/rules uses older style, but is readable enough
 * There are some warnings about not checking the return code of fgets() in Console.c
 * Spot-checking the code, it has some old conventions and isn't doing bounds checking on strcpy or checking return codes. However, because of the old conventions, these string operations are happening on the stack or our compiler hardening should cover them
 * There aren't any important bugs in Debian or Ubuntu
 * There is no CVE history and nothing in the code dictates a more in-depth security review.

ACK provided the compiler warnings are addressed and the patches sent to Debian.