Comment 46 for bug 1621507

Hi,
I've reviewed the changes that Mathieu has suggested at https://launchpadlibrarian.net/295312215/isc-dhcp_4.3.3-5ubuntu15.2~mtrudel4_4.3.3-5ubuntu15.2~mtrudel5.diff.gz .

I'm fine to let what he has go in there. I suggest, however, that we drop the exposing of dhclient variables to the /run/net-* scripts. This can easily be accomplished by dropping the 'for prefix in' loop in debian/initramfs-tools/lib/etc/dhcp/dhclient-enter-hooks.d/config .

The gain in removing that is not exposing the implementation detail or as-yet-unused variable names to the user and thus needing to support them. Adding "may be used later" type things to an SRU should be done with great hesitation. To be clear, in the /run/net-eth0.conf file, we'll have things like:
   * reason
   * ip6_address
in addition to things like:
   * IPV6ADDR

The lower case variables are copied through from dhclient-script's environment, and are dhclient specific. Going forward these may be hard to support if Ubuntu ever moved off dhclient (such as to networkd).

I'm willing to leave that up to the SRU team to decide, but feel that it should be identified.

I'm OK with it going in as it is, I'll not fight this any more.