Comment 38 for bug 1621507

Revision history for this message
Robie Basak (racb) wrote :

We discussed this on IRC in #ubuntu-release and agreed on the following plan of action:

0. cyphermox has uploaded open-iscsi to xenial and yakkety
1. rbasak will review open-iscsi (only) for acceptance into {xenial,yakkety}-proposed. Go back to step 0 for diff changes as needed, but there are no other blockers on the bug or on initramfs-tools or isc-dhcp
2. Nobody will upload isc-dhcp or initramfs-tools to the SRU queues in relation to this issue until open-iscsi finishes the SRU process in the usual way. Other unrelated SRUs to isc-dhcp and initramfs-tools are unaffected.
3. cyphermox will get consensus on the diffs for isc-dhcp and initramfs-tools
4. smoser will review and +1 the diffs (else go back to 3)
5. cypermox will upload isc-dhcp and initramfs-tools together to the xenial and yakkety queues for SRU processing in the usual way

This assumes that:
* Nobody has an objection to the current open-iscsi diff
* Nobody expects the open-iscsi diff to need to change based on the conclusion of the changes to be made to isc-dhcp and initramfs-tools

[rbasak] IMHO, the open-iscsi change seems straightforward enough to not be as concerned about regressions as I am with the previous initramfs-tools regression. So I think it's OK that open-iscsi dep8 is currently failing in Zesty. We can check to see that it passes in Xenial and Yakkety before releasing to -updates. I would still expect future initramfs-tools and isc-dhcp SRUs to be well tested in the development release, however.

There is a whitespace indetation inconsistency in the diff, but this went into zesty-proposed as well, and would create diff noise when comparing that. The mistake's been made, so I'll leave it as is.

Similarly, the whitespace change dropping an extra space in an if statement shouldn't really be part of the SRU, but I'll leave it as-is in order to make progress.