Comment 32 for bug 1621507

I've just took a read of the code that landed. Over all, the new code is much more suitable for SRU. I think it still has some issues though.

a.) we use 'grep' and 'cat' extensively in the new code. Most could be replaced with case statements or other shell builtin such as 'case' and 'read' and avoid subprocesses and their overhead. This is not broken, but slower boot as a result.

b.) ipconfig would set the 'hostname' in the dhcp request to the value in the 5th token of ip=. I do not believe that is being done now.

c.) at least 1 dhclient process will end up running after exiting the initramfs exits, and won't' have access to its open files. I'm not sure what the behavior will be, but its possible that this process could decide at re-lease time to take the interface down since it would not have its lease database around. I say at least due to bug 1633619. If we ever re-try, I suspect we'll have one for each loop.

Do we know what happens to this uprooted dhclient process?

d.) The ipconfig path that was left on will now have 'sleep's inserted and will as a result take much longer than necessary if it ever does not get a lease on the first try.

'b' is definitely a change in behavior. We really need to know what happens on 'c', and 'd' seems like it should be fixed as it negatively affects the 'ip=' path.