Comment 17 for bug 893091

Revision history for this message
In , Johnp-redhat (johnp-redhat) wrote :

Did a bunch of work and fixed all the issues for Python 2.6 (e.g. it passes make check). Simon, one thing that stumped me was the different ways we extend base types for variant_level. Why are some done with C extensions to the struct and others use attr? I noticed with the long object trying to covert it to a struct extension made the values you put in off by a power of two when you go to print it out.

I'm having issue compiling under 3.1. I get this:

libtool: link: gcc -shared .libs/abstract.o .libs/bus.o .libs/bytes.o .libs/conn.o .libs/conn-methods.o .libs/containers.o .libs/debug.o .libs/exceptions.o .libs/float.o .libs/generic.o .libs/int.o .libs/libdbusconn.o .libs/mainloop.o .libs/message-append.o .libs/message.o .libs/message-get-args.o .libs/module.o .libs/pending-call.o .libs/server.o .libs/signature.o .libs/string.o .libs/validation.o -L/lib -ldbus-1 -Wl,-soname -Wl,_dbus_bindings.so -Wl,-version-script -Wl,.libs/_dbus_bindings.ver -o .libs/_dbus_bindings.so
/usr/bin/ld:.libs/_dbus_bindings.ver:2: syntax error in VERSION script

I think it has something to do with moving from init_dbus_bindings to PyInit__dbus_bindings. It seems to not find any public methods. For instance in the 2.6 version the .ver file has this in it:

{ global:
init_dbus_bindings;
local: *; };

In 3.1 it has this:

{ global:
local: *; };

Not sure how to fix that.

We need to also think how we are going to support dual targets in the same autotools files and in the python files. David suggested running 2to3 during compile time.