* the changelog entry needs to document all the *current* changes between Debian and Ubuntu as well as the patches that have been dropped since the merge. Using the last merge log entry (0.10.0-1ubuntu1) as a template is usually a good way to start.
* debian/control: I would use a new line for all of the Ubuntu dependencies in order to make the diff easier to review. If Debian adds some dependencies to the line it would inter-mix with the Ubuntu addition making the review harder (ie put erlang-crypto, erlang-inets, erlang-xmerl, on its own line).
* Breaks/Replaces for 0.10.0~svn818859-0ubuntu1 are no longer necessary since upgrade from lucid are the only one supported. It should also make the delta with Debian smaller - so easier to review.
* refer this bug number in the changelog entry:
* Merge from debian unstable. Remaining changes: (LP: #591444)
I would also suggest to use bzr branches instead of patches attached to this bug. Using merge proposal will make it easier for the review process as well.
A few comments on the attached patch:
* the changelog entry needs to document all the *current* changes between Debian and Ubuntu as well as the patches that have been dropped since the merge. Using the last merge log entry (0.10.0-1ubuntu1) as a template is usually a good way to start. svn818859- 0ubuntu1 are no longer necessary since upgrade from lucid are the only one supported. It should also make the delta with Debian smaller - so easier to review.
* debian/control: I would use a new line for all of the Ubuntu dependencies in order to make the diff easier to review. If Debian adds some dependencies to the line it would inter-mix with the Ubuntu addition making the review harder (ie put erlang-crypto, erlang-inets, erlang-xmerl, on its own line).
* Breaks/Replaces for 0.10.0~
* refer this bug number in the changelog entry:
* Merge from debian unstable. Remaining changes: (LP: #591444)
I would also suggest to use bzr branches instead of patches attached to this bug. Using merge proposal will make it easier for the review process as well.