On 02.03.2010 10:14, Abel Deuring wrote:
> On 02.03.2010 00:17, Brian Murray wrote:
>> Abel - what will happen in the case that an invalid or non-existent
>> HWDB-Submission is used when reporting a bug in Launchpad?
>
>
> unfortunately, nothing... The line
> "CheckboxSubmission: fee5e196cb921cbd36888f428b38b488" is at present
> simply not processed...
>
> I filed bug 530556 about it.
...and this is complete nonsense -- I was too stupid to find the code
when I wrote the answer.
lp.bug.browser.bugtarget.FileBugViewBase.submit_bug_action does indeed
create links between bugs and HWDB submissions:
for submission_key in extra_data.hwdb_submission_keys: submission = submission_set.getBySubmissionKey( submission_key, self.user)
if submission is not None: bug.linkHWSubmission(submission)
(line 648).
So: A link between a bug and a HWDB submission is created, if the the
HWDB submission exists. If doesn't for whichever reason (mostly likely
because checkbox did create a submission ID but nothing was uploaded or
an error like a timeout occurred during the upload), the invalid /
non-extistent submission key is silently ignored.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02.03.2010 10:14, Abel Deuring wrote: sion: fee5e196cb921cb d36888f428b38b4 88" is at present
> On 02.03.2010 00:17, Brian Murray wrote:
>> Abel - what will happen in the case that an invalid or non-existent
>> HWDB-Submission is used when reporting a bug in Launchpad?
>
>
> unfortunately, nothing... The line
> "CheckboxSubmis
> simply not processed...
>
> I filed bug 530556 about it.
...and this is complete nonsense -- I was too stupid to find the code browser. bugtarget. FileBugViewBase .submit_ bug_action does indeed
when I wrote the answer.
lp.bug.
create links between bugs and HWDB submissions:
for submission_key in extra_data. hwdb_submission _keys:
submissio n = submission_ set.getBySubmis sionKey(
submission_ key, self.user)
bug. linkHWSubmissio n(submission)
if submission is not None:
(line 648).
So: A link between a bug and a HWDB submission is created, if the the enigmail. mozdev. org
HWDB submission exists. If doesn't for whichever reason (mostly likely
because checkbox did create a submission ID but nothing was uploaded or
an error like a timeout occurred during the upload), the invalid /
non-extistent submission key is silently ignored.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iD4DBQFLjjryekB Phm8NrtARAsmwAJ Y6m31N9lwmSYMi8 HaOrEVDxEQcAJ98 rq0r HIbqNSg= =
bp0H3NEemAkQnnZ
=gXiC
-----END PGP SIGNATURE-----