Comment 5 for bug 530380

Revision history for this message
Abel Deuring (adeuring) wrote : Re: [Bug 530380] Re: checkbox writes to .cache/checkbox/submission before submission completes

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02.03.2010 10:14, Abel Deuring wrote:
> On 02.03.2010 00:17, Brian Murray wrote:
>> Abel - what will happen in the case that an invalid or non-existent
>> HWDB-Submission is used when reporting a bug in Launchpad?
>
>
> unfortunately, nothing... The line
> "CheckboxSubmission: fee5e196cb921cbd36888f428b38b488" is at present
> simply not processed...
>
> I filed bug 530556 about it.

...and this is complete nonsense -- I was too stupid to find the code
when I wrote the answer.
lp.bug.browser.bugtarget.FileBugViewBase.submit_bug_action does indeed
create links between bugs and HWDB submissions:

         for submission_key in extra_data.hwdb_submission_keys:
             submission = submission_set.getBySubmissionKey(
                 submission_key, self.user)
             if submission is not None:
                 bug.linkHWSubmission(submission)

(line 648).

So: A link between a bug and a HWDB submission is created, if the the
HWDB submission exists. If doesn't for whichever reason (mostly likely
because checkbox did create a submission ID but nothing was uploaded or
an error like a timeout occurred during the upload), the invalid /
non-extistent submission key is silently ignored.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD4DBQFLjjryekBPhm8NrtARAsmwAJY6m31N9lwmSYMi8HaOrEVDxEQcAJ98rq0r
bp0H3NEemAkQnnZHIbqNSg==
=gXiC
-----END PGP SIGNATURE-----