Comment 11 for bug 1708376

Revision history for this message
jian.song (jiansong) wrote :

I tried it, it seems to be first update_override, and then through the apply_override to complete the configuration of the write. apply_override where it looks like the best choice.

Well, I've seen you about the root-related spec. In fact, this is a very good proposal, but I think your spec write and I often seem not the same, not sure whether this format is complete.

In addition, I think we are now the primary task is to complete the reconstruction of this problem Adminclient. Then we can be prepared to increase the root-related functions.

My previous fix is ​​a failure, so I would like to ask your opinion, I hope to be able to come up with enough to fix the bug code. And then wait for your spec to be added after the other.

By the way,I feel that part of your code is redundant....

...
    def apply_overrides (self, client, overrides):
        for prop_name, prop_args in overrides.items ():
            args_string = self._join_lists (
                self._value_converter.to_strings (prop_args), '')
            client.config_set (prop_name, args_string)
            self.admin = self._build_admin_client ()
            self.status = RedisAppStatus (self.admin)
`` ``

It seems that this can be done, I think we can rebuild the client every time.
Of course it might take into account your changes because of your spec.