Must correct condition ">= 0" to "is not None" in quotas_client.py file
As per Jay Pipes Comment in
https:/
Below was the comment:
Although it is technically legal to compare None to 0, it isn't particularly recommended. Could you replace all the '>= 0' occurrences in this file with "is not None"?
Should just be like this:
if injected_
...
The reason for this is partly so we are able to test things like setting cores == 0 (to effectively disable an account).
If I missed the use of >= 0 in the JSON client, please forgive me and correct that file as well. Thanks!
Hence I raise this blue print so as to implement the comment.
Blueprint information
- Status:
- Complete
- Approver:
- Ravikumar Venkatesan
- Priority:
- Undefined
- Drafter:
- None
- Direction:
- Needs approval
- Assignee:
- Rajalakshmi Ganesan
- Definition:
- Approved
- Series goal:
- None
- Implementation:
-
Implemented
- Milestone target:
- None
- Started by
- Rajalakshmi Ganesan
- Completed by
- Rajalakshmi Ganesan
Related branches
Related bugs
Sprints
Whiteboard
Gerrit topic: https:/
Addressed by: https:/
Correction in quota_client's condition logic
