Prevent trigger API from DoS when trigger ID is exposed

Registered by James Li

A token is not needed for consuming solum trigger API, that may be a vulnerability for DoS, especially when trigger ID is exposed. We propose the following approach to solve this issue. When solum creates a plan, a secret key is generated and put into db, also registered with user. For the Github-hosted code we can leverage its webhook API (https://developer.github.com/v3/repos/hooks/#create-a-hook) to register the key with the repo securely. So each time Github sends out a request (e.g. on a pull request) to solum trigger API, a signature is computed from the payload by using the key and included in its 'X-Hub-Signature' header. Solum can then do a hash compare to decide whether to accept or reject the request.

Blueprint information

Status:
Complete
Approver:
None
Priority:
Undefined
Drafter:
James Li
Direction:
Needs approval
Assignee:
James Li
Definition:
Obsolete
Series goal:
None
Implementation:
Unknown
Milestone target:
None
Completed by
Adrian Otto

Related branches

Sprints

Whiteboard

(?)

Work Items

This blueprint contains Public information 
Everyone can see this information.

Subscribers

No subscribers.