Make 5.7 RelWithDebInfo build type define NDEBUG
See https:/
We need to make Percona Server 5.7 RelWithDebInfo define NDEBUG so that debug specific assertions/code are not compiled into the release build.
Analyzing a grep of NDEBUG in the codebase, here are the bits that are impacted :
- plugin/
- storage/ndb uses NDEBUG (do we care?)
- storage/
- regex looks for NDEBUG but only if REDEBUG is not defined, seems OK
- extra/yassl uses NDEBUG, not sure if this is an opportunity for a runtime improvement?
- extra/protobuf uses NDEBUG, I don't know what protobuf is and if this is something that needs investigation
- ./plugin/
Discussion among the team and desk testing a prototype along with a preliminary Jenkins run reveals that this seems to be a fairly low risk change.
Blueprint information
- Status:
- Complete
- Approver:
- George Ormond Lorch III
- Priority:
- High
- Drafter:
- George Ormond Lorch III
- Direction:
- Approved
- Assignee:
- George Ormond Lorch III
- Definition:
- Approved
- Series goal:
- Accepted for 5.7
- Implementation:
- Implemented
- Milestone target:
- 5.7.20-18
- Started by
- George Ormond Lorch III
- Completed by
- George Ormond Lorch III