Add local hacking for oslo-incubator
The idea from keystone blueprint [1].
Hacking is a great start at automating checks for common style issues. There are still lots of things that it is not checking for that it probably should. The local hacking ease reviewer burden . This is the list of from [1][2] that would be nice to move into an automated check:
- use import style 'from openstack.common.* import' not use 'import openstack.common.*'
- assertIsNone should be used when using None with assertEqual
- _() should not be used in debug log statements
-do not use 'assertTrue(
-do not use 'assertEqual(
[1] https:/
[2] https:/
Blueprint information
- Status:
- Not started
- Approver:
- None
- Priority:
- Undefined
- Drafter:
- ChangBo Guo(gcb)
- Direction:
- Needs approval
- Assignee:
- ChangBo Guo(gcb)
- Definition:
- New
- Series goal:
- None
- Implementation:
-
Unknown
- Milestone target:
- None
- Started by
- Completed by
Whiteboard
Gerrit topic: https:/
Addressed by: https:/
Add check import style hacking in gate
Addressed by: https:/
hacking:
Gerrit topic: https:/
