Keep sensitive information out of node attributes

mapleoin: I think there is a valid use case for storing passwords as attributes in the case where both the chef-server and the nodes are inside an internal network which is considered secure. Some products (e.g. http://crowbar.github.io) rely on attributes for passing passwords around. That being said, I agree that the default should be to store passwords in databags and that is what we are currently doing AFAIK. See the use_databags attribute in the -common cookbook.

jswarren: The issue is that in some OS recipes (e.g. mysql-server), passwords are being copied from data bags into node attributes, which means that they can be read via the knife node edit command. If data bags are going to be used, the values extracted from them should be directly assigned to resources, instead of indirectly assigning them to resources via node attributes. Otherwise, one might as well use node attributes and not bother with data bags.

Gerrit topic: https://review.openstack.org/#q,topic:bp/no-secret-attributes,n,z

Addressed by: https://review.openstack.org/118649
    Set mysql root password directly on resource

Addressed by: https://review.openstack.org/112141
    Keep sensitive information out of node attributes