Comment 22 for bug 515507

On 22/04/10 07:54, Greg wrote:
> I use 5.03, 5.06 and 5.07 versions of server and do not play to
> make upgrade every days (for free) with the risk to loose
> customers datas.

Sure, and we only accept bugfixes in stable, features/enhancements are
for trunk, for this very reason.

> As I said, I saw the opened bug on launchpad and just push the work I
> had already done, but why opening a critical bug if we don't require
> module document to have SFTP ? it's just a whish.

Exactly, the critical status was put by the original reporter. That's
why I changed it to medium, even then only because the IP detection did
not work correctly so in some cases you had no way to make the FTP
server accessible from the network (which is a bug).

The rest is indeed wishlist.

> You can effectivly uninstall module but it's easier and more secure
> to be able to desactivate it with config.

That's debatable, but ok, I would still vote for a clean option to
disable it temporarily (if it's not temporary, just uninstall it)

> If you approve the change to parameter disable_ftp_server
> I can take the action.
> Do you need a test on differents values like : true, 1, on (case insensible) ?

Sure, in that case please submit a merge proposal on
openobject-addons/trunk, and introduce an 'ftp_server_disabled' option.
For the test please use regular Python boolean testing, so something
like the following to support 1/True/true/on/whatever:
    if HOST and not config.get('ftp_server_disabled'):
       # start the server....

Thanks a lot!