Comment 19 for bug 515507

Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote : Re: [Bug 515507] Re: Cannot desactivate FTP on DMS !

On 21/04/10 09:38, Greg wrote:
> I've a database with more than 2 millions hosts names (60% from US, 20% from asia, 20% from europa) and never found an host called "none".
> Even if someone choose this strange name, he can set the IP adress directly.

Yes, but if possible I'd like making the parameters to OpenERP as easy
to use as possible, and this mechanism seems a bit complicated to
understand for a newcomer (and how is the user supposed to guess that
'none' is not a valid ftp_serve_host for an obscure reason.)

> Sorry I found this solution (setting host to none) simple and functional, but I'm weird about your proposals. :-)
> why not an other settings like disable_ftp_server ? - if you think that really make a difference -

Yes I would prefer a separate parameter, unless we change the whole
configuration to support None *and* False values for all parameters,
which appropriate semantics, in which case it will become obvious to
everyone that using 'None' as a hostname is not allowed, as for any
other config option, unless you want to disable it. (and then lowercase
'none' would not make sense)

But the first question to ask is: now that in trunk you can install
document_ftp separately from document, why would you need to disable the
FTP server?
If you don't need it, don't install it, or uninstall it.

What do you think?