Comment 16 for bug 515507

Summary so far:

1. For stable, I have applied a modified version of Joël's patch (rev 2701 <email address hidden>)
@Joël: as you guessed, we can't put the default as 127.0.0.1 in 5.0 because it could potentially break many local installations where they rely on the fact that 0.0.0.0 is used when the detection fails. But at least now you can override the default in the configuration in all case.
This bug was in fact indeed a wishlist but given that auto-detection is unreliable let's consider it a valid bug in stable with a workaround for bad auto-detection.

2. For trunk it's already merged by Xavier, and I'm all ok for the more restrictive default of 127.0.0.1.

3. For document_sftp, as it's in extra-addons, any member of ~openerp-commiter can do it. => Joël ?
Greg's patch looks okay. And his proposal of allowing both key and password auth for sftp sounds good too (but haven't looked at that code in his branch).

Speaking of code, Greg and Xavier I have a question about what you merged in trunk (rev 3058), specifically this test at document_ftp/ftpserver/__init__.py:62:

   if HOST.lower() == 'none':

Hrm ... what exactly are you trying to achieve?
Do you plan to allow setting the host to the string None to disable the ftp? Or is this a (very wrong) way of testing for None?
In any case this doesn't look right, if only because 'none' could very well be a valid DNS alias for a local IP (people have strange nicknames for their computers sometimes)

Thanks everyone for your time and contribution!