Allow Volume Operations When Shelved

Registered by Paul Murray on 2015-10-22

This spec-less blueprint enables the attach volume and detach volume operations when an instance is in shelved or shelved_offloaded states.

At the moment volumes cannot be attached or detached when an instance has been shelved. These operations can be done when the instance is paused or stopped so it seems odd not to do it for shelved instances as well.

The case for the shelved state is similar to stopped or paused because the instance is still on the host, so this is covered by changing the allowed states for detach_volume() and attach_volume() in the compute API.

The case for the shelved_offloaded state requires a couple of new methods for attach and detach similar to the way bdms are dealt with in _local_delete() in the compute API class which deletes instances that have been offloaded.

Blueprint information

Status:
Complete
Approver:
John Garbutt
Priority:
Low
Drafter:
Paul Murray
Direction:
Approved
Assignee:
Paul Murray
Definition:
Approved
Series goal:
Accepted for mitaka
Implementation:
Implemented
Milestone target:
milestone icon mitaka-3
Started by
Paul Murray on 2015-12-17
Completed by
Paul Murray on 2016-02-05

Related branches

Sprints

Whiteboard

Because this changes the API, this will need a spec. --johnthetubaguy 20141104
Done - see below. -- PaulMurray

Gerrit topic: https://review.openstack.org/#q,topic:bp/volume-ops-when-shelved,n,z

Addressed by: https://review.openstack.org/243096 <=== Spec for Mitaka - MERGED
    Allow volume operations when shelved

Addressed by: https://review.openstack.org/264853 <== MERGED
    Adding guard on None value for some helpers method

Addressed by: https://review.openstack.org/259528 <== MERGED
    Adding volume operations for shelved instances

Addressed by: https://review.openstack.org/265898 <== MERGED
    Enable volume operations for shelved instances

This spec is complete - but we are adding a functional test because of issues with CI not working properly with micro versions.

Addressed by: https://review.openstack.org/277463
    Add tests to attach/detach vols for shelved server

Gerrit topic: https://review.openstack.org/#q,topic:call_terminate_connection_libvirt_cleanup,n,z

Addressed by: https://review.openstack.org/257275
    Call terminate_connection when shelve_offloading

(?)

Work Items

Dependency tree

* Blueprints in grey have been implemented.

This blueprint contains Public information 
Everyone can see this information.

Subscribers

No subscribers.