VMware: support ephemeral disks (partial - no resize)

Registered by Yaguang Tang

Current VMware Hyper doesn't support ephemeral disk and doesn't honor root disk size of a flavor .
This blueprint will enhance the current VMware Hyper to support ephemeral disk and different root disk size based on flavor.

Blueprint information

Status:
Complete
Approver:
John Garbutt
Priority:
Medium
Drafter:
Yaguang Tang
Direction:
Approved
Assignee:
Yaguang Tang
Definition:
Approved
Series goal:
Accepted for kilo
Implementation:
Implemented
Milestone target:
milestone icon 2015.1.0
Started by
John Garbutt
Completed by
John Garbutt

Related branches

Sprints

Whiteboard

I would like to see some discussion around this topic and how it will work with VMware templates and other techniques people have discussed adding to the driver. --hartsocks

Gerrit topic: https://review.openstack.org/#q,topic:bp/improve-vmware-disk-usage,n,z

Addressed by: https://review.openstack.org/33238
    Ehance VMware Hyper instance disk usage.

From IRC discussion:
* grow and shrink(?) a VMDK to match the size specified in the flavor.
* attach new disks that only live as long as the VM you attach them to
* possible dependency on blueprint vmware-image-clone-strategy

Addressed by: https://review.openstack.org/37659
    Enhance VMware Hyper instance disk usage.

Addressed by: https://review.openstack.org/43994
    VMwareVCDriver Fix sparse disk copy error on spawn

Addressed by: https://review.openstack.org/40298
    Fix snapshot failure with VMwareVCDriver

Addressed by: https://review.openstack.org/46653
    Enhance VMware instance disk usage

Addressed by: https://review.openstack.org/51793
    Add ephemeral disk support for VMware

[alaski] Since there are reviews up and in progress for this blueprint I'm assuming it's intended for Icehouse so I've set the series and milestone. Please modify them if I'm mistaken.

Addressed by: https://review.openstack.org/72719
    VMware create_virtual_disk refactor

Addressed by: https://review.openstack.org/66523
    VMware: factor out management of controller keys and unit numbers

Addressed by: https://review.openstack.org/73865
    VMware create_virtual_disk refactor

Addressed by: https://review.openstack.org/73965
    VMware: remove unused parameter from _wait_from_task

Gerrit topic: https://review.openstack.org/#q,topic:bug/1257683,n,z

Abandoned:
==========
https://review.openstack.org/#/c/33238/
https://review.openstack.org/#/c/37659/
https://review.openstack.org/#/c/46653/
https://review.openstack.org/#/c/72719/

Merged (Havanna):
===============
https://review.openstack.org/#/c/43994/
https://review.openstack.org/#/c/40298/

Merged (Icehouse):
================
https://review.openstack.org/#/c/66523/
https://review.openstack.org/#/c/73965/

Ephemeral disk support (pending patches)
=================================
https://review.openstack.org/#/c/73865/
https://review.openstack.org/#/c/51793/

Renamed, to better reflect what this is doing, if it had this name before, it would have got a higher priority --johnthetubaguy

Apologies, this missed the deadline for Feature Freeze. Please rebase patches as soon as Juno opens, and we will try to get this in during that period. --johnthetubaguy (5th March 2014)

Unapproved - please re-submit via nova-spec --johnthetubagy (20th March 2014)

I have re-proposed this for Juno: https://review.openstack.org/#/c/86074/ -- hartsock (8 April 2014)

Gerrit topic: https://review.openstack.org/#q,topic:bp/and,n,z

Addressed by: https://review.openstack.org/86074
    Propose: VMware ephemeral disk support

Gerrit topic: https://review.openstack.org/#q,topic:bp/vmware-spawn-refactor,n,z

Addressed by: https://review.openstack.org/86441
    VMWare: spawn refactor - phase 1 - create_virtual_disk

We need some code for this to be up for review, but moved to medium priority due for feature parity reasons --johnthetubaguy (24th June 2014)

Seems unlikely right now for juno, moving to low priority --johnthetubaguy 29th July 2014

Feature Proposal Freeze means this must not land in juno, because it appears like the code is not all currently ready to be reviewed. To be able to merge in kilo, we would first need to merge a kilo spec. More details on the exact process will be available on the ML shortly. --johnthetubaguy 22nd August 2014

Gerrit topic: https://review.openstack.org/#q,topic:bp/vmware-ephemeral-disk-support,n,z

Addressed by: https://review.openstack.org/109432
    VMware: ephemeral disk support

Addressed by: https://review.openstack.org/121409
    VMware: fix resize of ephemeral disks

So under kilo rules, this doesn't need a spec, I can just approve this BP. --johnthetubaguy (8th October 2014)

garyk [Monday Oct 13 2014]: The following patches complete the BP. These are based on the spawn refactor code (added in Juno):
- https://review.openstack.org/#/c/109432/ (ephemeral disk support with boot)
- https://review.openstack.org/#/c/121409/ (resize support for ephemeral disks)

Moving to kilo-2, as its not got all its changes merged yet. --johnthetubaguy 16th December 2014

Addressed by: https://review.openstack.org/130521
    VMware: refactor utility functions related to VMDK

Addressed by: https://review.openstack.org/144881
    VMware: add in a utility method for detaching devices

Addressed by: https://review.openstack.org/145007
    VMware: refactor resize code

Addressed by: https://review.openstack.org/145744
    VMware: ensure that correct disk details are returned

Addressed by: https://review.openstack.org/145174
    VMware: add in utility methods for copying and deleting disks

Gerrit topic: https://review.openstack.org/#q,topic:bp/vmware-driver-domain-metadata,n,z

https://review.openstack.org/#/c/109432/

Its totally unclear about the state of this blueprint, but marking this as partially complete for kilo now, adn the above patch has merged. --johnthetubaguy 5th Feb 2015

(?)

Work Items

This blueprint contains Public information 
Everyone can see this information.